Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trap and report error when hostname is null/empty (uplift to 1.50.x) #17919

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Apr 4, 2023

Manual uplift of #17917
Fixes brave/brave-browser#28940
Fixes brave/brave-browser#29502
Fixes brave/brave-browser#29477

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton bsclifton added this to the 1.50.x - Release milestone Apr 4, 2023
@bsclifton bsclifton requested a review from a team as a code owner April 4, 2023 20:14
@bsclifton bsclifton added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-linux-arm64 labels Apr 4, 2023
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Apr 5, 2023

Verification PASSED using

Brave | 1.50.113 Chromium: 112.0.5615.49 (Developer Build) (64-bit)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Windows 11 Version 22H2 (Build 22621.1413)
  • Installed 1.50.113
  • launched Brave
  • enabled brave://flags/#brave-vpn
  • Logged into Brave VPN with Prod credentials
  • Enabled VPN via VPN panel

Confirmed Brave no longer crashes and Failed to write config error is shown as expected

image

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.50.x approved 👍 QA has verified that the crash doesn't occur anymore via 1.52.x as per #17917 (comment) and verified via 1.50.x using a PR build as per #17919 (comment).

@kjozwiak kjozwiak merged commit 4379740 into 1.50.x Apr 5, 2023
@kjozwiak kjozwiak deleted the bsc-fix-vpn-windows-crash-1.50.x branch April 5, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants