Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable ReportingObserver and make noop #24726

Merged

Conversation

ShivanKaul
Copy link
Collaborator

@ShivanKaul ShivanKaul commented Jul 18, 2024

Resolves brave/brave-browser#39759

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#39759

@ShivanKaul ShivanKaul force-pushed the bugfix/make-reporting-observer-noop-instead-of-disable branch from 529f4b2 to 5cd781a Compare July 18, 2024 17:28
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src++

@ShivanKaul ShivanKaul merged commit 017fec0 into master Jul 19, 2024
16 checks passed
@ShivanKaul ShivanKaul deleted the bugfix/make-reporting-observer-noop-instead-of-disable branch July 19, 2024 16:19
@github-actions github-actions bot added this to the 1.70.x - Nightly milestone Jul 19, 2024
brave-builds added a commit that referenced this pull request Jul 22, 2024
bsclifton pushed a commit that referenced this pull request Jul 22, 2024
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.70.12 Chromium: 127.0.6533.57 (Official Build) nightly (64-bit)
-- | --
Revision | 5755980f479ca93ac5b74023fad08fb5556a5503
OS | Windows 11 Version 23H2 (Build 22631.3880)

Using the STR/Cases outlined via brave/brave-browser#39759 (comment), ensured that LastPass was working correctly as per the following:

Example Example Example Example
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants