Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable ReportingObserver and make noop (uplift to 1.68.x) #24781

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Re-enable ReportingObserver and make noop (uplift to 1.68.x) #24781

merged 1 commit into from
Jul 22, 2024

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jul 22, 2024 •
edited by kjozwiak
Loading

Manual uplift of #24726
Resolves brave/brave-browser#39759

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton bsclifton added this to the 1.68.x - Release milestone Jul 22, 2024
@bsclifton bsclifton requested a review from a team as a code owner July 22, 2024 17:26
kjozwiak
kjozwiak approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.68.x approved 👍 QA has verified the PR on Nightly using 1.70.x as per #24726 (comment).

@kjozwiak kjozwiak merged commit 18c3fbf into 1.68.x Jul 22, 2024
15 checks passed
@kjozwiak kjozwiak deleted the pr24726_bugfix/make-reporting-observer-noop-instead-of-disable_1.68.x branch July 22, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
1.68.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@bsclifton @kjozwiak @brave-builds