Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update brave-ui to fix monthly tip clipping #2590

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Conversation

cg505
Copy link
Contributor

@cg505 cg505 commented Jun 4, 2019

See brave/brave-ui#489 and brave/brave-ui#496.
Fixes brave/brave-browser#4503.

Submitter Checklist:

Test Plan:

See brave/brave-ui#489.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@cg505 cg505 requested review from cezaraugusto, ryanml and NejcZdovc and removed request for cezaraugusto June 4, 2019 17:34
@cg505 cg505 self-assigned this Jun 4, 2019
@cg505 cg505 changed the title update brave-ui update brave-ui to fix mothly tip clipping Jun 4, 2019
@ryanml ryanml added this to the 0.68.x - Nightly milestone Jun 4, 2019
@cg505 cg505 force-pushed the wallet-tip-select branch 2 times, most recently from 727b6d7 to 09d25d9 Compare June 4, 2019 18:49
@bsclifton bsclifton changed the title update brave-ui to fix mothly tip clipping update brave-ui to fix monthly tip clipping Jun 5, 2019
@cg505 cg505 force-pushed the wallet-tip-select branch 3 times, most recently from bf784a1 to db2a3b1 Compare June 6, 2019 21:05
@cg505 cg505 merged commit 49530cc into master Jun 7, 2019
@cg505 cg505 deleted the wallet-tip-select branch June 7, 2019 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BAT is sometimes truncated on panel for 'Tip this site monthly' value
2 participants