Update l10n XTB and messages.json for 76.0.3809.87 #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarolin
force-pushed
the
76.0.3809.87_localization
branch
2 times, most recently
from
6a16cd0
to
6fc90d4
Compare
In each .xtb file we create, strip all children from <ph> tags and remove innter text if it start with $ (so that $1 text would be removed, but something like '<a href="$1"...' would not. This is needed so that multiple replacement placeholders aren't generated by the resource data pack loader.
mkarolin
force-pushed
the
76.0.3809.87_localization
branch
from
6fc90d4
to
61fb8b1
Compare
|
@mkarolin whoops - just noticed the If so, can you create uplifts? 😄 |
|
@bsclifton, will do. WIP was just in case there were comments on the Transifex script changes. |
mkarolin
changed the title
mkarolin
pushed a commit
that referenced
this pull request
Aug 2, 2019
Update l10n XTB and messages.json for 76.0.3809.87
mkarolin
pushed a commit
that referenced
this pull request
Aug 2, 2019
Update l10n XTB and messages.json for 76.0.3809.87
mkarolin
pushed a commit
that referenced
this pull request
Aug 2, 2019
Update l10n XTB and messages.json for 76.0.3809.87
This was referenced Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#5500
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
N/A
Reviewer Checklist:
After-merge Checklist:
changes has landed on.