Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update l10n XTB and messages.json for 76.0.3809.87 (0.69.x) #3082

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Aug 2, 2019

Fixes brave/brave-browser#5500
Uplift request from #3074

Update l10n XTB and messages.json for 76.0.3809.87
@mkarolin mkarolin added this to the 0.69.x - Dev milestone Aug 2, 2019
@mkarolin mkarolin requested a review from a team August 2, 2019 17:27
@mkarolin mkarolin self-assigned this Aug 2, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Aug 4, 2019

@simonhong looks like there's a few errors. Mind double checking and making sure these errors aren't associated with the above PR?

Check out from version control error

Unit test failure via npm run test -- brave_unit_tests Release --output brave_unit_tests.xml

Unit test failure via npm run test -- brave_browser_tests Release --output brave_browser_tests.xml

@mkarolin
Copy link
Collaborator Author

mkarolin commented Aug 5, 2019

@kjozwiak, the failures weren't related to the PR, the first was due to the CI machine running out of space, the other 2 we've seen sporadically lately. I reran the job and it completed successfully.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srirambv, @LaurenWags, and I are ++ on these changes! 😄 Thanks, @mkarolin! 😄👍

@bsclifton bsclifton merged commit 058cd84 into 0.69.x Aug 5, 2019
@bsclifton bsclifton deleted the 76.0.3809.87_localization-0.69.x branch August 5, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants