Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounting for AC in NTP widget contrib totals #3868

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Accounting for AC in NTP widget contrib totals #3868

merged 1 commit into from
Nov 7, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 4, 2019

Fixes brave/brave-browser#6740

The previously utilized tipsTotal from brave://rewards page utils did not account for a-c in the balance report.

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 0.73.x - Nightly milestone Nov 4, 2019
@ryanml ryanml requested a review from a team November 4, 2019 06:50
@ryanml ryanml self-assigned this Nov 4, 2019
@ryanml ryanml merged commit 8684b7c into master Nov 7, 2019
@ryanml ryanml deleted the ac-ntp-fix branch November 7, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewards NTP widget is not reflecting AC
2 participants