Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards NTP widget is not reflecting AC #6740

Closed
LaurenWags opened this issue Nov 3, 2019 · 3 comments · Fixed by brave/brave-core#3868
Closed

Rewards NTP widget is not reflecting AC #6740

LaurenWags opened this issue Nov 3, 2019 · 3 comments · Fixed by brave/brave-core#3868

Comments

@LaurenWags
Copy link
Member

Description

Auto contribute amount is not being reflected on NTP widget.

Steps to Reproduce

Unsure. @ryanml has a profile where issue is occurring, but QA should check the following scenarios:

  1. profile where AC has already occurred for the month --> upgrade to version with NTP widget. Is AC reflected on NTP widget?
  2. profile where AC has not yet occurred for the month --> upgrade to version with NTP widget. Have AC go thru. Is AC reflected on NTP widget?
  3. Clean profile with NTP widget. Have AC go thru. Is AC reflected on NTP widget?
    4-6. Repeat above cases but with recurring monthly tips

Actual result:

(image from @AndriusA )
image (1)

Expected result:

NTP widget should reflect tips, monthly tips, and auto contributions.

Reproduces how often:

unsure

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @mandar-brave @brave/legacy_qa

@LaurenWags
Copy link
Member Author

Looks like this might be localized to auto contribute only, monthly recurring tip was reflected on the widget:
Screen Shot 2019-11-03 at 4 44 21 PM

@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 - 0.71.111

image

@btlechowski
Copy link

btlechowski commented Dec 3, 2019

Verification passed on

Brave 1.3.50 Chromium: 79.0.3945.56 (Official Build) nightly (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS Ubuntu 18.04 LTS

Verified the test plan from the description.
Upgraded profile from 1.2.x:
image

Clean profile:
image

Verification passed on

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Clean profile: (Trigger AC with one-time and monthly tips)
Verified AC value reflected in NTP
image
Triggered the 2nd AC in the same profile and verified NTP widget rewards value updated correctly
Verified AC value reflected in NTP
image
Upgrade profile: (0.71.104 ->No NTP widget->Trigger AC with one-time and monthly tips->Upgrade to 1.3.x)
Verified AC value reflected in NTP
image
Upgrade profile: (1.2.x ->Setup AC with one-time and monthly tips before AC , upgrade to 1.3.x)
Verified AC value reflected in NTP - encountered #7709 (comment)

Verified passed with

Brave 1.3.92 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified STR from description
  • Verified when AC occurred before upgrade to version with this fix, that AC is correctly reflected on NTP widget:

6740-case1

* Verified when AC occurs after upgrade to version with this fix, that AC is correctly reflected on NTP widget:

6740-case2

* Verified on a clean profile that AC is correctly reflected on NTP widget:

6740-case3

* Verified one time tips, recurring tips and AC are all reflected on NTP widget:

6740-ac1timeandrecurtip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment