Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expends contribution info table #4048

Merged
merged 4 commits into from
Nov 27, 2019
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Nov 21, 2019

Resolves brave/brave-browser#6942

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Nov 21, 2019
@NejcZdovc NejcZdovc self-assigned this Nov 21, 2019
@NejcZdovc NejcZdovc force-pushed the contribution-info-database branch 7 times, most recently from 156477b to ab15c4e Compare November 25, 2019 11:18
@NejcZdovc NejcZdovc requested a review from a team November 25, 2019 12:26
@NejcZdovc NejcZdovc marked this pull request as ready for review November 25, 2019 12:26
@NejcZdovc NejcZdovc force-pushed the contribution-info-database branch 3 times, most recently from dca094d to 69237b9 Compare November 26, 2019 06:25
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This change allows CI to pass but no longer supports one-time tips.
Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on #4087 for iOS implementation. For now, I have removed build failures (however iOS will not function correctly when merged)

@NejcZdovc NejcZdovc merged commit e947629 into master Nov 27, 2019
@NejcZdovc NejcZdovc deleted the contribution-info-database branch November 27, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand contributon_info table
5 participants