-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expends contribution info table #4048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
contribution-info-database
branch
7 times, most recently
from
November 25, 2019 11:18
156477b
to
ab15c4e
Compare
NejcZdovc
requested review from
gdregalo,
kylehickinson and
tmancey
as code owners
November 25, 2019 12:26
NejcZdovc
force-pushed
the
contribution-info-database
branch
3 times, most recently
from
November 26, 2019 06:25
dca094d
to
69237b9
Compare
masparrow
reviewed
Nov 26, 2019
components/brave_rewards/browser/database/database_contribution_info.cc
Outdated
Show resolved
Hide resolved
masparrow
reviewed
Nov 26, 2019
masparrow
reviewed
Nov 26, 2019
components/brave_rewards/browser/database/publisher_info_database_unittest.cc
Show resolved
Hide resolved
NejcZdovc
force-pushed
the
contribution-info-database
branch
from
November 26, 2019 14:32
69237b9
to
edfc5c1
Compare
masparrow
reviewed
Nov 26, 2019
masparrow
approved these changes
Nov 26, 2019
gdregalo
approved these changes
Nov 26, 2019
tmancey
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change allows CI to pass but no longer supports one-time tips.
kylehickinson
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on #4087 for iOS implementation. For now, I have removed build failures (however iOS will not function correctly when merged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#6942
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.