Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand contributon_info table #6942

Closed
NejcZdovc opened this issue Nov 15, 2019 · 7 comments · Fixed by brave/brave-core#4048
Closed

Expand contributon_info table #6942

NejcZdovc opened this issue Nov 15, 2019 · 7 comments · Fixed by brave/brave-core#4048
Assignees

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Nov 15, 2019

Test Plan

Perform several auto contributes, one time tips, and recurring tips and confirm the contribution_info and contribution_info_publishers tables are populated as expected per #6942 (comment)

Check AC, one time tips, and recurring tips using:

  • user funded anon wallet
  • VG funded wallet
  • KYC'd uphold user wallet

Right now this is how table looks like:

image

We will need to expand it so that we can handle retry logic and logging an actual contribution data, so that we don't need ledger_state logging anymore. Because VG simplified things a lot, tables should be quite clean. For now VG don't need any special data that needs to be stored so we don't need dumping table for it.

This is a current proposal:

image

@NejcZdovc NejcZdovc added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 15, 2019
@NejcZdovc NejcZdovc self-assigned this Nov 15, 2019
@NejcZdovc
Copy link
Contributor Author

blocked on #6544

@LaurenWags
Copy link
Member

@NejcZdovc what should be manually QA'd with this issue?

@NejcZdovc
Copy link
Contributor Author

@LaurenWags test plan could be that you do couple of contributions and make sure that this two tables are populated correctly

@LaurenWags
Copy link
Member

mix of AC, one time tips and recurring tips?

@NejcZdovc
Copy link
Contributor Author

yup

@LaurenWags
Copy link
Member

Adding QA/Blocked label until #7844 and #7526 are resolved, encountering both of these issues while testing.

@LaurenWags
Copy link
Member

LaurenWags commented Jan 31, 2020

Verified passed with

Brave 1.3.106 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified 1 time tip, recurring tip, and AC using previously self-funded anon wallet:

anon-6942

anon-6942pt2

  • Verified 1 time tip, recurring tip, and AC using anon wallet funded via UGP (virtual) grant:

Screen Shot 2020-01-31 at 3 49 59 PM

Screen Shot 2020-01-31 at 3 50 16 PM

  • Verified 1 time tip, recurring tip, and AC using KYC'd user wallet:

KYCd-6942

KYCd-6942pt2

Verification passed on

Brave 1.3.107 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified 1 time tip, recurring tip, and AC using previously self-funded anon wallet:
    image
    image
    image
  • Verified 1 time tip, recurring tip, and AC using anon wallet funded via UGP (virtual) grant:
    image
    image
    image
  • Verified 1 time tip, recurring tip, and AC using KYC'd user wallet:
    image
    image
    image

Verification passed on

Brave 1.3.107 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS
  • Verified 1 time tip, recurring tip, and AC using previously self-funded anon wallet:
    image
    image

  • Verified 1 time tip, recurring tip, and AC using anon wallet funded via UGP (virtual) grant:
    image
    image

  • Verified 1 time tip, recurring tip, and AC using KYC'd user wallet:
    image
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants