Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes remove duplicate matched segments when triggering ads #4084

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Nov 27, 2019

Fixes brave/brave-browser#7118

Submitter Checklist:

Test Plan:

See brave/brave-browser#7118

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey
Copy link
Collaborator Author

tmancey commented Nov 27, 2019

Failed due to unrelated network audit

@tmancey tmancey merged commit f0eb527 into master Nov 27, 2019
@tmancey tmancey deleted the issues/7118 branch November 27, 2019 13:29
petemill pushed a commit that referenced this pull request Jul 27, 2020
Update audit script used by `npm run test-security` to skip vendor fo…
petemill pushed a commit that referenced this pull request Jul 28, 2020
Update audit script used by `npm run test-security` to skip vendor fo…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate matched segments when triggering ads
2 participants