Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes contribution with unblinded tokens (1.4.x) #4341

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 9, 2020

Uplift of #4317

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc added this to the 1.4.x - Dev milestone Jan 9, 2020
@NejcZdovc NejcZdovc requested a review from a team January 9, 2020 14:00
@NejcZdovc NejcZdovc self-assigned this Jan 9, 2020
@NejcZdovc NejcZdovc changed the title Fixes contribution with unblinded tokens Fixes contribution with unblinded tokens (1.4.x) Jan 9, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Jan 9, 2020

Waiting on #4317 (comment)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins & CI/Travis passed without any errors. Both @NejcZdovc and QA has gone through Nightly to ensure that the PR was working as expected as per #4317 (comment).

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 1ceb507 into 1.4.x Jan 13, 2020
@kjozwiak kjozwiak deleted the tip-vg-1.4 branch January 13, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants