Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ads enabled by default on upgrade for new ad regions - 1.3.x #4394

Merged
merged 1 commit into from
Jan 25, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jan 19, 2020

@tmancey tmancey added this to the 1.3.x - Beta milestone Jan 19, 2020
@tmancey tmancey requested a review from a team January 19, 2020 12:25
@tmancey tmancey self-assigned this Jan 19, 2020
@tmancey tmancey changed the title Fixes ads enabled by default on upgrade for new ad regions Fixes ads enabled by default on upgrade for new ad regions - 1.3.x Jan 19, 2020
@tmancey
Copy link
Collaborator Author

tmancey commented Jan 19, 2020

@kjozwiak

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.4.2 approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues. @LaurenWags also went through Nightly as per #4392 (comment).

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants