Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 79.0.3945.130 to Chromium 80.0.3987.78 (1.4.x) #4469

Merged
merged 5 commits into from
Feb 4, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jan 31, 2020

Fixes brave/brave-browser#7255
Fixes brave/brave-browser#7975
Related PR: brave/brave-browser#7996

Uplift request from #4374

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin
Copy link
Collaborator Author

The commits include #4412. Those should go away once #4412 has been uplifted and this PR is rebased.

@NejcZdovc NejcZdovc removed their request for review January 31, 2020 18:59
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

components/ntp_sponsored_images: LGTM

samartnik and others added 4 commits February 3, 2020 10:03
Upgrade from Chromium 79.0.3945.130 to Chromium 80.0.3987.66
Fix macOS signing problem with Chromium 80 (which causes Brave to exit immediately)
Add Sparkle hardened runtime support
@mkarolin mkarolin changed the title WIP: Upgrade from Chromium 79.0.3945.130 to Chromium 80.0.3987.66 (1.4.x) Upgrade from Chromium 79.0.3945.130 to Chromium 80.0.3987.66 (1.4.x) Feb 3, 2020
@mkarolin
Copy link
Collaborator Author

mkarolin commented Feb 3, 2020

Rebased over 1.4.x after #4412 merged.

@mkarolin mkarolin requested a review from a team February 3, 2020 15:33
Upgrade from Chromium 80.0.3987.66 to Chromium 80.0.3987.78.
@mkarolin mkarolin changed the title Upgrade from Chromium 79.0.3945.130 to Chromium 80.0.3987.66 (1.4.x) Upgrade from Chromium 79.0.3945.130 to Chromium 80.0.3987.78 (1.4.x) Feb 3, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Feb 4, 2020

Looks like the only failures are related to audit-network which is a known issue and not related to this specific PR.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. Both Linux and macOS failed due to audit-network as per #4469 (comment) which is a known issue and not related to this specific .

Please make sure that all the correct labels are being used and the associated issue(s) are moved into the correct milestone.

@kjozwiak kjozwiak merged commit 2dc8d67 into 1.4.x Feb 4, 2020
@kjozwiak kjozwiak deleted the 80.0.3987.66-1.4.x branch February 4, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants