Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes monthly report for versions before 1.3 #5216

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 10, 2020

Resolves brave/brave-browser#8987

Submitter Checklist:

Test Plan:

  • start browser with a profile that has history of rewards before 2020
  • open monthly statement
  • make sure that you only see Feb 2020 and forward

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.9.x - Nightly milestone Apr 10, 2020
@NejcZdovc NejcZdovc requested a review from a team April 10, 2020 06:10
@NejcZdovc NejcZdovc self-assigned this Apr 10, 2020
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.3.1 was available from 13th November 2019?

@NejcZdovc
Copy link
Contributor Author

@tmancey 1.3 was released February 7, 2020. Nightly was Nov 2019

@tmancey
Copy link
Collaborator

tmancey commented Apr 10, 2020

@tmancey 1.3 was released February 7, 2020. Nightly was Nov 2019

1.3.1 was released to "nightly" in November, however, @NejcZdovc has clarified it was decided that this fix should only consider "release"

@tmancey tmancey self-requested a review April 10, 2020 11:23
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc
Copy link
Contributor Author

CI failed on a known thing

@tmancey tmancey self-requested a review April 10, 2020 11:47
@LaurenWags
Copy link
Member

Verified passed with

Brave 1.9.21 Chromium: 81.0.4044.92 (Official Build) nightly (64-bit)
Revision 32921c79b6f01a0fb2deef0e1d45b42f96581051-refs/branch-heads/4044@{#883}
OS macOS Version 10.14.6 (Build 18G3020)

Personal profile monthly statement on 1.8.75 (Beta):
Screen Shot 2020-04-14 at 1 57 32 PM

Personal profile using 1.9.21 (Nightly)
Screen Shot 2020-04-14 at 2 06 26 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do not provide monthly statements for data prior to 1.3.x
3 participants