Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes monthly report for versions before 1.3 (uplift to 1.8.x) #5239

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 14, 2020

Uplift of #5216
Fixes brave/brave-browser#8987

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Apr 14, 2020
@brave-builds brave-builds added this to the 1.8.x - Beta milestone Apr 14, 2020
@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Apr 14, 2020
@NejcZdovc NejcZdovc removed their request for review April 14, 2020 05:12
@kjozwiak
Copy link
Member

@kjozwiak
Copy link
Member

@kjozwiak
Copy link
Member

QA verified #5216 on the latest master as per #5216 (comment) 👍

@bsclifton bsclifton requested review from a team and removed request for bbondy, bsclifton, kjozwiak, rebron and srirambv April 21, 2020 21:34
@bsclifton
Copy link
Member

bsclifton commented Apr 21, 2020

macOS build finished after updating the Chromium source- however, it ran into this intermittent issue:

14:38:48  In file included from ../../brave/browser/ui/views/infobars/brave_wayback_machine_infobar_contents_view.cc:19:
14:38:48  ../../chrome/browser/themes/theme_properties.h:13:10: fatal error: 'chrome/common/buildflags.h' file not found
14:38:48  #include "chrome/common/buildflags.h"
14:38:48           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
14:38:48  1 error generated.

https://ci.brave.com/job/brave-browser-build-pr/job/pr5216_monthly-prior_1.8.x/10/execution/node/343/log/

Restarting

@kjozwiak
Copy link
Member

Looks macOS ran into a few intermittent issues that are already known:

xUnit failed to publish as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5216_monthly-prior_1.8.x/12/execution/node/361/

test-browser failed due to BraveRewardsBrowserTest.NotVerifiedWallet as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5216_monthly-prior_1.8.x/12/execution/node/378/log/

22:02:21  [  FAILED  ] BraveRewardsBrowserTest.NotVerifiedWallet, where TypeParam =  and GetParam() =  (6216 ms)
22:02:21  [507/507] BraveRewardsBrowserTest.NotVerifiedWallet (6332 ms)
22:02:21  1 test failed:
22:02:21      BraveRewardsBrowserTest.NotVerifiedWallet (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2323)

brave/brave-browser#9339 as filed for the above issue.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. Please make sure that the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 9e7e710 into 1.8.x Apr 22, 2020
@kjozwiak kjozwiak deleted the pr5216_monthly-prior_1.8.x branch April 22, 2020 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants