Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds remove option to ac table in rewards #537

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 1, 2018

Resolves brave/brave-browser#1379

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. clean profile
  2. enable rewards
  3. visit some site (wait on it for 10s)
  4. go back to rewards settings
  5. make sure that X is there and you can remove site

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Oct 1, 2018
@NejcZdovc NejcZdovc requested a review from ryanml October 1, 2018 22:34
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc merged commit 443e6a8 into master Oct 1, 2018
@NejcZdovc NejcZdovc deleted the ac-topfive-remove branch October 1, 2018 22:41
NejcZdovc added a commit that referenced this pull request Oct 1, 2018
Adds remove option to ac table in rewards
NejcZdovc added a commit that referenced this pull request Oct 1, 2018
Adds remove option to ac table in rewards
@NejcZdovc
Copy link
Contributor Author

master 443e6a8
0.56.x e15792e
0.55.x 08f15f0

@bsclifton
Copy link
Member

Added merged/0.55.x label 😄

@NejcZdovc
Copy link
Contributor Author

@bsclifton thx for adding the label, please keep rewards tags on the PR

@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add remove to auto-contribute table
4 participants