Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds balance info to internals page #5415

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Adds balance info to internals page #5415

merged 1 commit into from
Apr 29, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 29, 2020

Resolves brave/brave-browser#9512

Submitter Checklist:

Test Plan:

  • enable rewards
  • claim promotions
  • connect KYC uphold account
  • go to internals page
  • make sure that you see correct balance there

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.10.x - Nightly milestone Apr 29, 2020
@NejcZdovc NejcZdovc requested a review from a team April 29, 2020 07:36
@NejcZdovc NejcZdovc self-assigned this Apr 29, 2020
@NejcZdovc NejcZdovc force-pushed the balance-internals branch 3 times, most recently from 6c33de8 to e2fc059 Compare April 29, 2020 07:40
@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Apr 29, 2020
@NejcZdovc
Copy link
Contributor Author

CI failed on a known problem, brave/brave-browser#9339. Everything else is good

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


const getWalletBalance = (wallets: Record<string, number>) => {
let items = []
for (let key in wallets) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: could this be a const instead?

@NejcZdovc NejcZdovc merged commit 2b7dcf9 into master Apr 29, 2020
@NejcZdovc NejcZdovc deleted the balance-internals branch April 29, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow a user to troubleshoot when display balance is not equal to Uphold balance
2 participants