"BraveRewardsBrowserTest.NotVerifiedWallet" occasionally timeout/fails

[kjozwiak]

Description

Started noticing that BraveRewardsBrowserTest.NotVerifiedWallet has been failing from time to time when reviewing uplift PRs.

18:40:26  [  FAILED  ] BraveRewardsBrowserTest.NotVerifiedWallet, where TypeParam =  and GetParam() =  (6072 ms)
18:40:26  [541/541] BraveRewardsBrowserTest.NotVerifiedWallet (6340 ms)
18:40:26  1 test failed:
18:40:26      BraveRewardsBrowserTest.NotVerifiedWallet (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2326)
18:40:26  null

Usually a restart resolves the above.

Steps to Reproduce

There's no STR as this usually intermittently happens when PRs are running through CI. However, there's been a few reports from several folks of the above failure.

Actual result:

Shouldn't be intermittently failing BraveRewardsBrowserTest.NotVerifiedWallet

Expected result:

Should be passing BraveRewardsBrowserTest.NotVerifiedWallet if there's no actual issues rather than intermitting failing due to timeout issues.

Reproduces how often:

I'm not 100% sure but it doesn't have too often.

Brave version (brave://version info)

N/A

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @bsclifton @NejcZdovc @bbondy

[emerick]

Ran successfully for me on Windows a few times, but then it generated this stack trace:

../../brave/components/brave_rewards/browser/rewards_service_browsertest_utils.cc(263): error: Expected equality of these values:
  true
  result
    Which is: a JavaScript error:
Error: Timed out waiting for '#on-boarding-verify-button'.
    at eval (__const_std::string&_script__:14:18)

Stack trace:
Backtrace:
        rewards_service_browsertest_utils::WaitForElementThenClick [0x00007FF676E3A19F+325] (C:\work\brave-browser\src\brave\components\brave_rewards\browser\rewards_service_browsertest_utils.cc:263)
        BraveRewardsBrowserTest_NotVerifiedWallet_Test::RunTestOnMainThread [0x00007FF676E2CBB4+162] (C:\work\brave-browser\src\brave\components\brave_rewards\browser\rewards_service_browsertest.cc:2365)
        content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF67930C18C+696] (C:\work\brave-browser\src\content\public\test\browser_test_base.cc:676)
        ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00007FF679C1A8E3+4283] (C:\work\brave-browser\src\chrome\browser\chrome_browser_main.cc:1808)
        ChromeBrowserMainParts::PreMainMessageLoopRun [0x00007FF679C1976C+46] (C:\work\brave-browser\src\chrome\browser\chrome_browser_main.cc:1190)
        content::BrowserMainLoop::PreMainMessageLoopRun [0x00007FF6779324C9+55] (C:\work\brave-browser\src\content\browser\browser_main_loop.cc:1033)
        content::StartupTaskRunner::RunAllTasksNow [0x00007FF677C7287B+61] (C:\work\brave-browser\src\content\browser\startup_task_runner.cc:41)
        content::BrowserMainLoop::CreateStartupTasks [0x00007FF677931568+538] (C:\work\brave-browser\src\content\browser\browser_main_loop.cc:943)
        content::BrowserMainRunnerImpl::Initialize [0x00007FF677933EB8+98] (C:\work\brave-browser\src\content\browser\browser_main_runner_impl.cc:131)
        content::BrowserMain [0x00007FF67792FF3C+180] (C:\work\brave-browser\src\content\browser\browser_main.cc:43)
        content::RunBrowserProcessMain [0x00007FF67900899D+89] (C:\work\brave-browser\src\content\app\content_main_runner_impl.cc:531)
        content::ContentMainRunnerImpl::RunServiceManager [0x00007FF6790094BB+691] (C:\work\brave-browser\src\content\app\content_main_runner_impl.cc:965)
        content::ContentMainRunnerImpl::Run [0x00007FF6790091DB+291] (C:\work\brave-browser\src\content\app\content_main_runner_impl.cc:876)
        service_manager::Main [0x00007FF679A1D1EA+1202] (C:\work\brave-browser\src\services\service_manager\embedder\main.cc:423)
        content::ContentMain [0x00007FF67841404E+62] (C:\work\brave-browser\src\content\app\content_main.cc:19)
        content::BrowserTestBase::SetUp [0x00007FF67930BD88+1698] (C:\work\brave-browser\src\content\public\test\browser_test_base.cc:510)
        InProcessBrowserTest::SetUp [0x00007FF679304728+324] (C:\work\brave-browser\src\chrome\test\base\in_process_browser_test.cc:291)

../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc(2375): error: Value of: base::StartsWith( current_url.spec(), braveledger_uphold::GetUrl() + "/authorize/", base::CompareCase::INSENSITIVE_ASCII)
  Actual: false
Expected: true
Stack trace:
Backtrace:
        BraveRewardsBrowserTest_NotVerifiedWallet_Test::RunTestOnMainThread [0x00007FF676E2CD42+560] (C:\work\brave-browser\src\brave\components\brave_rewards\browser\rewards_service_browsertest.cc:2372)
        content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF67930C18C+696] (C:\work\brave-browser\src\content\public\test\browser_test_base.cc:676)
        ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00007FF679C1A8E3+4283] (C:\work\brave-browser\src\chrome\browser\chrome_browser_main.cc:1808)
        ChromeBrowserMainParts::PreMainMessageLoopRun [0x00007FF679C1976C+46] (C:\work\brave-browser\src\chrome\browser\chrome_browser_main.cc:1190)
        content::BrowserMainLoop::PreMainMessageLoopRun [0x00007FF6779324C9+55] (C:\work\brave-browser\src\content\browser\browser_main_loop.cc:1033)
        content::StartupTaskRunner::RunAllTasksNow [0x00007FF677C7287B+61] (C:\work\brave-browser\src\content\browser\startup_task_runner.cc:41)
        content::BrowserMainLoop::CreateStartupTasks [0x00007FF677931568+538] (C:\work\brave-browser\src\content\browser\browser_main_loop.cc:943)
        content::BrowserMainRunnerImpl::Initialize [0x00007FF677933EB8+98] (C:\work\brave-browser\src\content\browser\browser_main_runner_impl.cc:131)
        content::BrowserMain [0x00007FF67792FF3C+180] (C:\work\brave-browser\src\content\browser\browser_main.cc:43)
        content::RunBrowserProcessMain [0x00007FF67900899D+89] (C:\work\brave-browser\src\content\app\content_main_runner_impl.cc:531)
        content::ContentMainRunnerImpl::RunServiceManager [0x00007FF6790094BB+691] (C:\work\brave-browser\src\content\app\content_main_runner_impl.cc:965)
        content::ContentMainRunnerImpl::Run [0x00007FF6790091DB+291] (C:\work\brave-browser\src\content\app\content_main_runner_impl.cc:876)
        service_manager::Main [0x00007FF679A1D1EA+1202] (C:\work\brave-browser\src\services\service_manager\embedder\main.cc:423)
        content::ContentMain [0x00007FF67841404E+62] (C:\work\brave-browser\src\content\app\content_main.cc:19)
        content::BrowserTestBase::SetUp [0x00007FF67930BD88+1698] (C:\work\brave-browser\src\content\public\test\browser_test_base.cc:510)
        InProcessBrowserTest::SetUp [0x00007FF679304728+324] (C:\work\brave-browser\src\chrome\test\base\in_process_browser_test.cc:291)

[NejcZdovc]

yes this is the same thing that we see on CI