Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NotVerifiedWallet browser test #5586

Merged
merged 1 commit into from
May 21, 2020

Conversation

emerick
Copy link
Contributor

@emerick emerick commented May 19, 2020

Resolves brave/brave-browser#9339

Submitter Checklist:

Test Plan:

  • Run the NotVerifiedWallet browser test and verify that it passes

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@emerick emerick requested review from ryanml and NejcZdovc May 19, 2020 00:40
@emerick emerick self-assigned this May 19, 2020
: <WalletSummary
reservedAmount={pendingTotal}
{
externalWallet
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change here is to not show the wallet wrapper until we have a valid external wallet.

@emerick emerick force-pushed the rewards-fix-not-verified-wallet-test branch 2 times, most recently from 6c87d5e to 7f24e37 Compare May 20, 2020 13:57
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emerick emerick force-pushed the rewards-fix-not-verified-wallet-test branch 2 times, most recently from a25d0b2 to 910e59b Compare May 20, 2020 17:00
@emerick emerick merged commit 5883d83 into master May 21, 2020
@emerick emerick deleted the rewards-fix-not-verified-wallet-test branch May 21, 2020 14:11
@NejcZdovc NejcZdovc added this to the 1.11.x - Nightly milestone May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"BraveRewardsBrowserTest.NotVerifiedWallet" occasionally timeout/fails
3 participants