Change adblock and TP from resource throttle to network delegate #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes it so empty data urls are used by default instead of blocking. Empty image data URLs for images. Fix brave/brave-browser#1430 Fix brave/brave-browser#1118 Fix brave/brave-browser#1428 Fix brave/brave-browser#1362
bbondy
commented
Oct 9, 2018
| } | ||
|
|
||
| if (IsBlockedResource(url)) { | ||
| request->Cancel(); |
There was a problem hiding this comment.
request->Cancel() not needed when you return net::ERR_ABORTED and actually it causes a debug assertion if you do it.
bbondy
added a commit
that referenced
this pull request
Oct 9, 2018
Change adblock and TP from resource throttle to network delegate
bbondy
added a commit
that referenced
this pull request
Oct 9, 2018
Change adblock and TP from resource throttle to network delegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If approved, please wait to merge until builds and tests finish on Windows and Linux.
This also makes it so empty data urls are used by default instead of
blocking. Empty image data URLs for images.
Fix brave/brave-browser#1430
Fix brave/brave-browser#1118
Fix brave/brave-browser#1428
Fix brave/brave-browser#1362
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: