Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads not blocked on Cnet.com #1118

Closed
srirambv opened this issue Sep 13, 2018 · 5 comments · Fixed by brave/brave-core#592
Closed

Ads not blocked on Cnet.com #1118

srirambv opened this issue Sep 13, 2018 · 5 comments · Fixed by brave/brave-core#592

Comments

@srirambv
Copy link
Contributor

Description

Ads not blocked on Cnet.com

Steps to Reproduce

  1. Visit any link on cnet.com
  2. Page shows ads which are not blocked even with adblock set to Block Ads
  3. Visit the same link on muon browser, all ads are blocked (see screenshot comparison)

Actual result:

image
Muon
image

Expected result:

All ads should be blocked by default

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.2 Chromium: 70.0.3538.12 (Official Build) (64-bit)
Revision ad61584ca32115f953ce656dd75b44f1c502a75d-refs/branch-heads/3538@{#179}
OS Windows

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @bbondy

@LaurenWags
Copy link
Member

Just noticed that b-c is being detected as an ad-blocker on an NYT article (using 0.55.3) and b-l (using 0.23.205) is not. https://www.nytimes.com/2018/09/12/opinion/new-york-primary-election-go-vote.html

screen shot 2018-09-13 at 9 23 01 am

@stshank
Copy link

stshank commented Sep 14, 2018

I have the opposite problem on CNET today: All non-ad graphics are blocked. Fresh install of Brave Core on Windows. Images come back if I take shields down. Version 0.55.3 Chromium: 70.0.3538.12 (Official Build) dev (64-bit)

image

@hferreiro
Copy link
Contributor

This is working with Brave 0.57.1

@bbondy
Copy link
Member

bbondy commented Oct 5, 2018

It's not working fully, it's just only reproducible on some machines.

bbondy added a commit to brave/brave-core that referenced this issue Oct 9, 2018
This also makes it so empty data urls are used by default instead of
blocking.  Empty image data URLs for images.

Fix brave/brave-browser#1430
Fix brave/brave-browser#1118
Fix brave/brave-browser#1428
Fix brave/brave-browser#1362
@bbondy bbondy added the QA/Yes label Oct 9, 2018
@srirambv
Copy link
Contributor Author

srirambv commented Oct 11, 2018

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

image

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows

Verified passed with

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

screen shot 2018-10-13 at 3 41 45 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment