Onboarding v2 dp #6234

deeppandya · 2020-07-28T18:34:49Z

Resolves : brave/brave-browser#9555

Submitter Checklist:

Test Plan:

Follow test plan on the issue. and follow the design spec as mention on the issue.

Reviewer Checklist:

New files have MPL-2.0 license header.
Request a security/privacy review as needed.
Adequate test coverage exists to prevent regressions
Verify test plan is specified in PR before merging to source

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on.
All relevant documentation has been updated.

SergeyZhukovsky

++

Add resources for onboardingv2

Update UI

Update code for animations

Add third party library for graph/chart

Add data table for brave stats Update code for brave stats

Update code with pref

Add datatable for saved bandwidth

Update code for stat site Update code with Saved bandwidth

Update BraveNewTabPageLayout for CR84 Remove Search onboarding Remove graph/chart library

Update code for highlighted view

Update code for4 animated bg

Update existing UI accordingly

Update UI for updated brave stats code Refactor code Update onboarding image Remove previous onborading images Remove unused images Refactor code to avoid warnings Remove unused onboarding code

Refactor onboarding

Fix CI error

Fix resources related error Fix resources related error Fix private tab test

mariospr · 2020-07-30T10:26:00Z

I rebased today on top of the latest master and I can't build on Linux anymore because of this PR, more specifically because of this: 72df475#diff-e9394688e89210103ace82f5b1b746ba

It seems like that commit introduced a dependency on android-specific code from components/brave_perf_predictor/browser/perf_predictor_tab_helper.cc, which is also built on (non-android) Linux.

I looked into the changes in there and I suppose it should be possible to add some preprocessor conditions to make sure that those includes, and the code used from them, are not used in Linux, but @deeppandya will probably know better 🙂

iefremov · 2020-07-30T11:01:02Z

components/brave_perf_predictor/browser/perf_predictor_tab_helper.cc

@@ -23,10 +25,10 @@ content::WebContents* GetWebContents(int render_process_id,
                                     int render_frame_id,
                                     int frame_tree_node_id) {
  content::WebContents* web_contents =
-      content::WebContents::FromFrameTreeNodeId(frame_tree_node_id);


@deeppandya would you mind restoring proper formatting as per Chromium code style? You can set up clang-format to automatically format code in your IDE

iefremov · 2020-07-30T11:02:42Z

BUILD.gn

+      "//brave/android/java/org/chromium/chrome/browser/onboarding/animations/privacy_protection.json",
+      "//brave/android/java/org/chromium/chrome/browser/onboarding/animations/save_data_and_battery.json",
+      "//brave/android/java/org/chromium/chrome/browser/onboarding/animations/website_loads_faster.json",
+      "//brave/android/java/org/chromium/chrome/browser/onboarding/animations/onboarding_ads_notification.json",


we should keep all these lists sorted, gn format makes it easy to fix @deeppandya

srirambv · 2020-08-19T11:22:16Z

Verification passed on OnePlus 6T with Android 10 running 1.14.44 x64 nightly build

Clean Install

Verified privacy stats onboarding is shown the moment browser is launched

First info card about `Privacy protection` highlights `Trackers & Ads blocked`	Second info card about `Save data and battery` highlights `Data Saved`	Third info card about `Websites loads faster` highlights `Est. Time saved`

The fourth info card about privacy stats doesn't highlight the stats button on NTP. Logged [Android] Get weekly reports info card doesn't show interaction hotspot for the stats button brave-browser#11325
Verified clicking Turn on privacy reports on the first screen and following through brings up the privacy reports modal once onboarding is completed

Light theme	Dark Theme

Verified swiping across the privacy onboarding brings up the fourth info card and clicking on Learn more starts the onboarding again

Light theme	Dark Theme

Clicking on Individual stats on NTP doesn't bring up the respective info card. Logged [Android] Clicking on individual stats doesn't bring up the specific info card brave-browser#11319

Search Engine discovery

Verified clicking on the URL bar brings up the SE onboarding
Verified changing default search engine via onboarding is retained
Verified changing/retaining default search engine is set for both normal and private tabs

Brave Shields

Verified visiting a page for the first time where nothing is blocked doesn't bring out the shields message
Verified visiting a page for the first time shows shields onboarding message when the page load is done
Verified clicking on the shields message opens the Shields panel
Onboarding message is not dismissed when a new tab is opened before page load completes [Android] Shields onboarding is not dismissed when a new tab is opened brave-browser#11318

Rewards

Verified on clean install clicking on the rewards button brings up rewards onboarding as per spec
Verified if not enabled, Rewards onboarding is shown upon launch after 4 days
Clicking on sample ad notification doesn't load the landing page. Logged [Android] Sample ad doesn't open landing page when rewards is enabled brave-browser#11323

Brave Desktop intro

Verified Brave Desktop intro card is shown after 12 days
Verified intro card is shown on a private tab if the browser is launched via private tab on the home screen

Light	Dark

Logged Fetches ETH icon from crx packager always in Android wallet (uplift to 1.33.x) #11326 for suggesting text colour change to not make it look like a clickable link

Upgrade Install

Verified stat button is shown on an upgrade on NTP
Verified interaction hotspot is shown on the stats button on NTP
Verified clicking it loads the privacy stats onboarding
Logged Separated Balances and Prices Calls (uplift to 1.33.x) #11324 for not showing the first info card in onboarding

Verification passed on Samsung Tab A with Android 10 running 1.14.44 x64 nightly build

Clean Install

Verified privacy stats onboarding is shown the moment browser is launched

First info card about `Privacy protection` highlights `Trackers & Ads blocked`	Second info card about `Save data and battery` highlights `Data Saved`	Third info card about `Websites loads faster` highlights `Est. Time saved`

The fourth info card about privacy stats doesn't highlight the stats button on NTP. Logged [Android] Get weekly reports info card doesn't show interaction hotspot for the stats button brave-browser#11325
Verified clicking Turn on privacy reports on the first screen and following through brings up the privacy reports modal once onboarding is completed

Light theme	Dark Theme

Verified swiping across the privacy onboarding brings up the fourth info card and clicking on Learn more starts the onboarding again

Light theme	Dark Theme

Clicking on Individual stats on NTP doesn't bring up the respective info card. Logged [Android] Clicking on individual stats doesn't bring up the specific info card brave-browser#11319

Search Engine discovery

Verified clicking on the URL bar brings up the SE onboarding
Verified changing default search engine via onboarding is retained
Verified changing/retaining default search engine is set for both normal and private tabs

Brave Shields

Verified visiting a page for the first time where nothing is blocked doesn't bring out the shields message
Verified visiting a page for the first time shows shields onboarding message when the page load is done
Verified clicking on the shields message opens the Shields panel
Onboarding message is not dismissed when a new tab is opened before page load completes [Android] Shields onboarding is not dismissed when a new tab is opened brave-browser#11318

Rewards

Verified on clean install clicking on the rewards button brings up rewards onboarding as per spec
Verified if not enabled, Rewards onboarding is shown upon launch after 4 days
Clicking on sample ad notification doesn't load the landing page. Logged [Android] Sample ad doesn't open landing page when rewards is enabled brave-browser#11323

Brave Desktop intro

Verified Brave Desktop intro card is shown after 12 days.
Verified intro card is shown on a private tab if the browser is launched via private tab on the home screen

Light	Dark

Logged Fetches ETH icon from crx packager always in Android wallet (uplift to 1.33.x) #11326 for suggesting text colour change to not make it look like a clickable link

Upgrade Install

Verified stat button is shown on an upgrade on NTP
Verified interaction hotspot is shown on the stats button on NTP
Verified clicking it loads the privacy stats onboarding
Logged Separated Balances and Prices Calls (uplift to 1.33.x) #11324 for not showing the first info card in onboarding

Tab specific issues

Privacy report modal scale is pretty small on tablet - [Android] Privacy report modal scale is pretty small on tablet brave-browser#11322
SE onboarding on tablet isn't smooth - [Android] SE onboarding on tablet isn't smooth brave-browser#11201

Note: Translations are not checked for any of the above

srirambv · 2020-08-21T10:56:33Z

Verification passed on OnePlus 6T with Android 10 running 1.14.57

Verified onboarding flow works as per spec and results are similar to Onboarding v2 dp #6234 (comment)

Verification passed on Samsung Tab A with Android 10 running 1.14.57

Verified onboarding flow works as per spec and results are similar to Onboarding v2 dp #6234 (comment)

deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jul 28, 2020

deeppandya added this to the 1.13.x - Nightly milestone Jul 28, 2020

deeppandya requested a review from SergeyZhukovsky July 28, 2020 18:34

deeppandya self-assigned this Jul 28, 2020

deeppandya mentioned this pull request Jul 28, 2020

Onboarding v2 #6233

Closed

32 tasks

SergeyZhukovsky approved these changes Jul 28, 2020

View reviewed changes

deeppandya force-pushed the onboarding_v2_dp branch from cd84be1 to eacc03d Compare July 29, 2020 00:24

deeppandya added 20 commits July 30, 2020 03:24

Add UI for onboardingv2

35f69fc

Add resources for onboardingv2

Add onboarding images

55b08cc

Add resources in .gni

2a0638d

Update UI

Update code with androidx library

78cc429

Update UI

Add Lottie library for animations

e634ec7

Add animations

52077cd

Update code for animations

Update newtabpage animation on page selection

2f12432

Add third party library for graph/chart

Add data table for brave stats

474c0bb

Update view pager indicators

cdcc9bb

Add data table for brave stats Update code for brave stats

Update view pager with dark/light mode

1320f5f

Update brave stats for animation

3772adf

Add stats icon

3c36f42

Update NTP for stats icon

0b988cd

Update code with pref

Update brave stats model code

72df475

Add Brave stats UI

f3f889d

Add datatable for saved bandwidth

Upfdate code for saved bandwidth

7e31bed

Update code for stat site Update code with Saved bandwidth

Update Bravestats UI for onboarding v2

f375f0e

Update BraveNewTabPageLayout for CR84 Remove Search onboarding Remove graph/chart library

Add highlighted view

a624f40

Update code for highlighted view

Open fragment in portrait

0008687

Add resources for existing onboarding

18ff2ce

Update code for4 animated bg

deeppandya added 7 commits July 30, 2020 03:25

Update shields tooltip

3c1348a

Update UI with highlight view

60437c3

Update existing UI accordingly

Update brave stats db code

e3c7699

Update UI for updated brave stats code Refactor code Update onboarding image Remove previous onborading images Remove unused images Refactor code to avoid warnings Remove unused onboarding code

Update layout for brave stats warning page

26653c7

Refactor onboarding

Enable search onboarding

c6a807c

Fix CI error

Fix lint error

4193574

Fix resources related error Fix resources related error Fix private tab test

Update code to fix tests

9302963

deeppandya force-pushed the onboarding_v2_dp branch from 28d2a36 to 9302963 Compare July 30, 2020 07:37

deeppandya merged commit 7c3ca0b into master Jul 30, 2020

deeppandya deleted the onboarding_v2_dp branch July 30, 2020 08:41

deeppandya mentioned this pull request Jul 30, 2020

Onboarding v2 dp 1.13.x (uplift to 1.13.x) #6263

Merged

4 tasks

mariospr mentioned this pull request Jul 30, 2020

Linux build broken on master (1.14.x) brave/brave-browser#11013

Closed

iefremov reviewed Jul 30, 2020

View reviewed changes

deeppandya mentioned this pull request Aug 4, 2020

Fix formatting for perf predictor tab helper #6337

Merged

srirambv mentioned this pull request Aug 31, 2020

Onboarding v2 with retention notification (uplift to 1.13.x) #6494

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Onboarding v2 dp #6234

Onboarding v2 dp #6234

deeppandya commented Jul 28, 2020

SergeyZhukovsky left a comment

mariospr commented Jul 30, 2020

iefremov Jul 30, 2020

iefremov Jul 30, 2020 •

edited

Loading

srirambv commented Aug 19, 2020 •

edited

Loading

srirambv commented Aug 21, 2020

Onboarding v2 dp #6234

Onboarding v2 dp #6234

Conversation

deeppandya commented Jul 28, 2020

Submitter Checklist:

Test Plan:

Reviewer Checklist:

After-merge Checklist:

SergeyZhukovsky left a comment

Choose a reason for hiding this comment

mariospr commented Jul 30, 2020

iefremov Jul 30, 2020

Choose a reason for hiding this comment

iefremov Jul 30, 2020 • edited Loading

Choose a reason for hiding this comment

srirambv commented Aug 19, 2020 • edited Loading

Note: Translations are not checked for any of the above

srirambv commented Aug 21, 2020

iefremov Jul 30, 2020 •

edited

Loading

srirambv commented Aug 19, 2020 •

edited

Loading