Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rewards panel behaviour dp #6378

Merged
merged 4 commits into from
Aug 11, 2020
Merged

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Aug 10, 2020

Resolves : brave/brave-browser#11113, brave/brave-browser#11094

Submitter Checklist:

Test Plan:

Follow the main issues to verify the test plans.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@deeppandya deeppandya self-assigned this Aug 10, 2020
@deeppandya deeppandya added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Aug 10, 2020
@deeppandya deeppandya added this to the 1.14.x - Nightly milestone Aug 10, 2020
@deeppandya deeppandya force-pushed the update_rewards_panel_behaviour_dp branch from 040be2e to 5cfe5e4 Compare August 11, 2020 02:20
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya merged commit ff1725d into master Aug 11, 2020
@deeppandya deeppandya deleted the update_rewards_panel_behaviour_dp branch August 11, 2020 03:42
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.14.32 x64 nightly build

  • Verified on a clean install rewards button has a ? as per specs
    image
  • Verified if rewards is not enabled on an older version and then upgraded to 1.14.32 red dot on rewards panel is replaced with?
  • Verified on a clean install visiting rewards page and opting in retains the ? on the panel and is removed when sample ad notification is shown
  • Verified if rewards is enabled via rewards page and the clicking the BR panel doesn't bring up the onboarding again

@deeppandya
Copy link
Contributor Author

Need to uplift this issue to 1.13. currently blocked on #6263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Rewards onboarding is shown even after rewards is enabled
3 participants