Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yandex implementation android #7258

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#12862

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Nov 26, 2020
@deeppandya deeppandya added this to the 1.19.x - Nightly milestone Nov 26, 2020
@deeppandya deeppandya self-assigned this Nov 26, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya merged commit d789d92 into master Nov 26, 2020
@deeppandya deeppandya deleted the yandex_implementation_android_2 branch November 26, 2020 23:16
@kjozwiak
Copy link
Member

kjozwiak commented Dec 2, 2020

Verification PASSED on Pixel 2 XL running Android 11 using 1.19.43 CR: 87.0.4280.67

  • ensured that Yandex was available as a choice via the SE onboarding in the following regions as per Introduce Yandex in some regions brave-browser#12327.
    • Russia, Belarus, Armenia and Kyrgyz
  • ensured that selecting Yandex from the SE onboarding switches the default SE for both Standard Tab & Private Tab
  • ensured that searching via the URL bar uses the clid=2423859 attribution
  • ensured that searching via yandex.ru doesn't use our clid=2423859 attribution

Screenshot_20201201-222849

Found brave/brave-browser#12979 while running through the above which will need to be fixed for 1.18.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yandex updates for Android
3 participants