[iOS-Sync] Delete Other Devices (Uplift to 1.18.x) #7576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s was removed). Adding back deleting other devices using the 1.20.x API (profile_helper). Changed ResetSync to use the brave_sync::ResetSync from profile_helper.
Brandon-T
requested review from
bridiver,
kylehickinson,
tmancey,
bsclifton,
darkdh,
AlexeyBarabash and
a team
Brandon-T
requested review from
iefremov,
mihaiplesa,
samartnik and
a team
as code owners
bsclifton
changed the title
| auto device_value = base::Value::FromUniquePtrValue(device->ToValue()); | ||
| bool is_current_device = | ||
| local_device_info ? local_device_info->guid() == device->guid() : false; | ||
| device_value.SetBoolKey("isCurrentDevice", is_current_device); | ||
| device_value.SetStringKey("guid", device->guid()); | ||
| device_value.SetBoolKey("supportsSelfDelete", |
There was a problem hiding this comment.
I can't find where supportsSelfDelete is used neither in branch ios/sync-delete-devices nor in https://github.com/brave/brave-ios . Or this is supposed in upcoming PRs?
There was a problem hiding this comment.
It would decide whether we allow users to delete remote devices from device list
There was a problem hiding this comment.
yeah, so this is for future use?
|
Quick context: Closed as we're going to base |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation Details
brave_services_keyResolves brave/brave-ios#3194 and brave/brave-ios#3195
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed).Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on.
Test Plan: