Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[Sync] Delete Other Devices Support #3195

Closed
Brandon-T opened this issue Jan 12, 2021 · 1 comment · Fixed by #3261
Closed

[Sync] Delete Other Devices Support #3195

Brandon-T opened this issue Jan 12, 2021 · 1 comment · Fixed by #3261
Assignees
@Brandon-T
Labels
Epic: Sync QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.24

Comments

@Brandon-T
Copy link
Collaborator

Problem Description

Desktop added a feature to delete other devices. This feature was NOT added to iOS by accident.. so now iOS needs to support deleting other devices on the sync chain AND it needs to support being deleted by other devices.

Implementation Details

  • iOS should support being deleted from sync chain by other devices such as Desktop and Android.
  • iOS should support deleting other devices from the sync chain (Desktop, Android, and other iOS devices).
@Brandon-T Brandon-T self-assigned this Jan 12, 2021
This was referenced Jan 12, 2021
Closed
Closed
Merged
Merged
@kylehickinson kylehickinson added this to the 1.23 milestone Jan 13, 2021
@bsclifton bsclifton mentioned this issue Jan 26, 2021
Merged
4 tasks
@iccub iccub modified the milestones: 1.23, 1.24 Jan 27, 2021
kylehickinson added a commit that referenced this issue Feb 3, 2021
@kylehickinson
Fix #3195, #3194: Fixing DeleteBookmark and Sync Delete Other Device.
0786cb2
@kylehickinson kylehickinson mentioned this issue Feb 3, 2021
Merged
7 tasks
kylehickinson added a commit that referenced this issue Feb 3, 2021
@kylehickinson
Fix #3195: Add ability to delete devices from sync chain
bcb2340
kylehickinson added a commit that referenced this issue Feb 5, 2021
@kylehickinson
Fix #3195: Add ability to delete devices from sync chain
e4807bb
@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14.4 running 1.24(21.3.24.11)

  • Verified remove device is shown when tapped on other devices
  • Verified remove confirmation is shown
  • Verified able to remove other devices from sync chain
image image

Verification passed on iPhone 7+ with iOS 14.4 running 1.24(21.3.24.11)

  • Verified remove device is shown when tapped on other devices
  • Verified remove confirmation is shown
  • Verified able to remove other devices from sync chain
image image

Verification passed on iPhone 7+ with iOS 14.4 running 1.24(21.3.24.11)

  • Verified remove device is shown when tapped on other devices
  • Verified remove confirmation is shown
  • Verified able to remove other devices from sync chain
image image

@kjozwiak kjozwiak mentioned this issue Apr 12, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

Labels
Epic: Sync QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.24
5 participants
@kylehickinson @Brandon-T @kjozwiak @iccub @srirambv