Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry referral ping if the referral ping has an error on retry. (uplift to 1.23.x) #8388

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Retry referral ping if the referral ping has an error on retry. (uplift to 1.23.x) #8388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32511c9
Retry referral ping if the referral ping has an error on retry.
yachtcaptain23 Mar 30, 2021
fb4cc82
referrals: stats: Always RETRY_ON_NETWORK_CHANGE
Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions browser/brave_stats/brave_stats_updater.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,8 @@ void BraveStatsUpdater::SendServerPing() {
->GetURLLoaderFactory();
simple_url_loader_ = network::SimpleURLLoader::Create(
std::move(resource_request), traffic_annotation);
simple_url_loader_->SetRetryOptions(
1, network::SimpleURLLoader::RETRY_ON_NETWORK_CHANGE);
simple_url_loader_->DownloadHeadersOnly(
loader_factory,
base::BindOnce(&BraveStatsUpdater::OnSimpleLoaderComplete,
Expand Down Expand Up @@ -412,6 +414,8 @@ void BraveStatsUpdater::SendUserTriggeredPing() {
->GetURLLoaderFactory();
simple_url_loader_ = network::SimpleURLLoader::Create(
std::move(resource_request), traffic_annotation);
simple_url_loader_->SetRetryOptions(
1, network::SimpleURLLoader::RETRY_ON_NETWORK_CHANGE);
simple_url_loader_->DownloadHeadersOnly(
loader_factory,
base::BindOnce(&BraveStatsUpdater::OnThresholdLoaderComplete,
Expand Down
6 changes: 6 additions & 0 deletions components/brave_referrals/browser/brave_referrals_service.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,8 @@ void BraveReferralsService::FetchReferralHeaders() {
referral_headers_loader_ = network::SimpleURLLoader::Create(
std::move(resource_request), traffic_annotation);
referral_headers_loader_->SetAllowHttpErrorResults(true);
referral_headers_loader_->SetRetryOptions(
1, network::SimpleURLLoader::RetryMode::RETRY_ON_NETWORK_CHANGE);
referral_headers_loader_->DownloadToString(
loader_factory,
base::BindOnce(&BraveReferralsService::OnReferralHeadersLoadComplete,
Expand Down Expand Up @@ -626,6 +628,8 @@ void BraveReferralsService::InitReferral() {
referral_init_loader_->SetAllowHttpErrorResults(true);
referral_init_loader_->AttachStringForUpload(BuildReferralInitPayload(),
"application/json");
referral_init_loader_->SetRetryOptions(
1, network::SimpleURLLoader::RetryMode::RETRY_ON_NETWORK_CHANGE);
referral_init_loader_->DownloadToString(
loader_factory,
base::BindOnce(&BraveReferralsService::OnReferralInitLoadComplete,
Expand Down Expand Up @@ -694,6 +698,8 @@ void BraveReferralsService::CheckForReferralFinalization() {
referral_finalization_check_loader_->SetAllowHttpErrorResults(true);
referral_finalization_check_loader_->AttachStringForUpload(
BuildReferralFinalizationCheckPayload(), "application/json");
referral_finalization_check_loader_->SetRetryOptions(
1, network::SimpleURLLoader::RetryMode::RETRY_ON_NETWORK_CHANGE);
referral_finalization_check_loader_->DownloadToString(
loader_factory,
base::BindOnce(
Expand Down