Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry referral ping if the referral ping has an error on retry. (uplift to 1.23.x) #8388

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

kkuehlz
Copy link
Contributor

@kkuehlz kkuehlz commented Mar 30, 2021

Partial uplift of #8382 and #8396. Only cherry picks the commit 5f1630b from the first PR, which is relevant for the regressions we are seeing with Android referrals in stable.

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@kkuehlz kkuehlz requested a review from simonhong as a code owner March 30, 2021 16:59
@kkuehlz kkuehlz requested a review from a team March 30, 2021 17:28
@kjozwiak
Copy link
Member

pylint-report failed on pre-init as per https://ci.brave.com/job/pr-brave-browser-uplift_android_referral_net_changed_1.23.x-pre-init/2/execution/node/138/log/. However, these warnings are known and not specific to this particular PR hence not blocking uplift.

audit_deps failed on post-init as per https://ci.brave.com/job/pr-brave-browser-uplift_android_referral_net_changed_1.23.x-post-init/2/execution/node/145/log/. However, these warnings are known and not specific to this particular PR hence not blocking uplift.

macOS failed due to test-browser failing as per https://ci.brave.com/job/pr-brave-browser-uplift_android_referral_net_changed_1.23.x-macos/2/execution/node/242/log/ & https://ci.brave.com/job/pr-brave-browser-uplift_android_referral_net_changed_1.23.x-macos/2/execution/node/245/log/. However, these failures are known and not specific to this particular PR hence not blocking uplift.

03:15:40  5 tests crashed:
03:15:40      BraveStatsUpdaterBrowserTest.StatsUpdaterMigration (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:275)
03:15:40      BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:154)
03:15:40      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:229)
03:15:40      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:327)
03:15:40      BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:191)

Linux failed due to test-browser failing as per https://ci.brave.com/job/pr-brave-browser-uplift_android_referral_net_changed_1.23.x-linux/2/execution/node/242/log/ & https://ci.brave.com/job/pr-brave-browser-uplift_android_referral_net_changed_1.23.x-linux/2/execution/node/245/log/. However, these failures are known and not specific to this particular PR hence not blocking uplift.

@kjozwiak kjozwiak added this to the 1.23.x - Beta milestone Mar 31, 2021
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.23.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8396 (comment). @keur helped us verify that everything looked good on server side and the referrals finalized.

@kjozwiak kjozwiak merged commit 6156110 into 1.23.x Mar 31, 2021
@kjozwiak kjozwiak deleted the uplift_android_referral_net_changed_1.23.x branch March 31, 2021 18:33
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants