Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "verify wallet" button on tip dialog rewards onboarding #8761

Merged
merged 1 commit into from
May 10, 2021

Conversation

zenparsing
Copy link
Collaborator

Resolves brave/brave-browser#15705

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@zenparsing zenparsing requested a review from emerick May 10, 2021 15:02
@zenparsing zenparsing requested a review from a team as a code owner May 10, 2021 15:02
@zenparsing zenparsing requested a review from bsclifton May 10, 2021 15:02
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjozwiak
Copy link
Member

post-init failed due to audit-deps warning(s) as per https://ci.brave.com/job/pr-brave-browser-ksmith-jp-tip-verify-button-post-init/1/execution/node/145/log/. However, the warning(s) are a known issue and unrelated to this RR.

test-browser failed on Linux as per https://ci.brave.com/job/pr-brave-browser-ksmith-jp-tip-verify-button-linux/1/testReport/. However, these are known intermittent issues unrelated to this specific PR.

linux / test-browser / BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion062WithRewardsEnabled_ForUnsupportedLocale_ForUnsupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled
linux / test-browser / BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion070WithRewardsAndAdsEnabled_ForSupportedLocale_ForNewlySupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled
linux / test-browser / BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion070WithRewardsAndAdsEnabled_ForSupportedLocale_ForUnsupportedLocale_RewardsShouldBeEnabled_AdsShouldBeEnabled
linux / test-browser / BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion070WithRewardsAndAdsEnabled_ForUnsupportedLocale_ForUnsupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled
linux / test-browser / BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion072WithRewardsAndAdsEnabled_ForSupportedLocale_ForNewlySupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled

Restarting Win x64 using WIPE_WORKSPACE which hopefully helps.

@zenparsing
Copy link
Collaborator Author

zenparsing commented May 10, 2021

CI

  • post-init failed on unrelated audit-deps issue
  • linux failed on unrelated BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath tests
  • macos failed on unrelated AdBlockServiceTest.CnameCloakedRequestsGetBlocked test
  • windows failed on unresolved CI issue when building unit tests, unit tests and browser tests passed locally

@kjozwiak
Copy link
Member

Adding the 1.26.x milestone as this landed in master 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verify my wallet button not working under rewards onboarding via tipping banner
3 participants