Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "verify wallet" button on tip dialog rewards onboarding (uplift to 1.24.x) #8765

Merged
merged 1 commit into from
May 11, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 10, 2021

Uplift of #8761
Resolves brave/brave-browser#15705

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team May 10, 2021 19:52
@brave-builds brave-builds self-assigned this May 10, 2021
@brave-builds brave-builds added this to the 1.24.x - Release #2 milestone May 10, 2021
@kjozwiak
Copy link
Member

post-init failed due to audit-deps failing as per https://ci.brave.com/job/pr-brave-browser-pr8761_ksmith-jp-tip-verify-button_1.24.x-post-init/1/execution/node/144/log/. However, this is a known warning/issue and unrelated to this specific PR.

@kjozwiak
Copy link
Member

kjozwiak commented May 10, 2021

Restarting Win as test-unit failed as per https://ci.brave.com/job/pr-brave-browser-pr8761_ksmith-jp-tip-verify-button_1.24.x-windows/1/execution/node/214/. @wknapik fixed the issue so it should pass now 👍

17:59:26  Recording test results
17:59:26  No test report files were found. Configuration error?

Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from ip-172-31-31-69.us-west-2.compute.internal/172.31.31.69:49720
		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1800)
		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)
		at hudson.remoting.Channel.call(Channel.java:1001)
		at hudson.FilePath.act(FilePath.java:1166)
		at hudson.FilePath.act(FilePath.java:1155)
		at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:107)
		at hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:149)
		at hudson.tasks.junit.JUnitResultArchiver.parseAndSummarize(JUnitResultArchiver.java:243)
		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:63)
		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:29)
		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
		at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
		at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
		at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
		at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
hudson.AbortException: No test report files were found. Configuration error?
	at hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:152)
	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3328)
	at hudson.remoting.UserRequest.perform(UserRequest.java:211)
	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
	at hudson.remoting.Request$2.run(Request.java:376)
	at hudson.remoting.InterceptingExecutorService.lambda$wrap$0(InterceptingExecutorService.java:78)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:119)
	at java.base/java.lang.Thread.run(Thread.java:834)

test-browser failed on macOS as per https://ci.brave.com/job/pr-brave-browser-pr8761_ksmith-jp-tip-verify-button_1.24.x-macos/1/testReport. However, these are known intermittent failures unrelated to this specific PR.

macos-x64 / test-browser / BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion070WithRewardsAndAdsEnabled_ForSupportedLocale_ForUnsupportedLocale_RewardsShouldBeEnabled_AdsShouldBeEnabled
macos-x64 / test-browser / BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion070WithRewardsAndAdsEnabled_ForUnsupportedLocale_ForUnsupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.24.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit c6c272d into 1.24.x May 11, 2021
@kjozwiak kjozwiak deleted the pr8761_ksmith-jp-tip-verify-button_1.24.x branch May 11, 2021 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants