This repository has been archived by the owner on Jun 6, 2019. It is now read-only.
3rd party fingerprinting protection #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
bbondy
approved these changes
Apr 1, 2018
|
I think tests are failing because you need to rebase on master, but pls make sure they are passing with rebased to master. |
bbondy
reviewed
Apr 4, 2018
| @@ -353,7 +353,8 @@ describe('braveShieldsPanelReducer', () => { | |||
| it('should call setAllowFingerprinting', function () { | |||
| assert.deepEqual( | |||
| shieldsPanelReducer(state, { | |||
| type: types.FINGERPRINTING_TOGGLED | |||
| type: types.BLOCK_FINGERPRINTING, | |||
| setting: 'allow', | |||
There was a problem hiding this comment.
I think lint would say no trailing comma there
bbondy
reviewed
Apr 4, 2018
app/background/api/shieldsAPI.ts
Outdated
| @@ -38,7 +40,7 @@ export const getShieldSettingsForTabData = (tabData?: chrome.tabs.Tab) => { | |||
| trackers: details[2].setting, | |||
| httpUpgradableResources: details[3].setting, | |||
| javascript: details[4].setting, | |||
| fingerprinting: details[5].setting | |||
| fingerprinting: fingerprinting | |||
There was a problem hiding this comment.
nit: just fingerprinting when name and value are named the same since ES6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: brave/brave-browser#126
requires: brave/brave-core#75