Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Commit

Permalink
Adding missing Histogram controller to debug menu and noticeAcknowleg…
Browse files Browse the repository at this point in the history
…ment
  • Loading branch information
soner-yuksel committed Nov 9, 2022
1 parent fed8f9e commit 0ca78cb
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ extension BrowserViewController {
onboardingP3ACalloutController.setLayoutState(state: state)

if !isOnboardingOrFullScreenCalloutPresented {
braveCore.p3aUtils.isNoticeAcknowledged = true
present(onboardingP3ACalloutController, animated: false)
}
}
Expand Down
8 changes: 8 additions & 0 deletions Client/Frontend/Settings/SettingsViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,14 @@ class SettingsViewController: TableViewController {
selection: { [unowned self] in
self.displayBraveSearchDebugMenu()
}, accessory: .disclosureIndicator, cellClass: MultilineValue1Cell.self),
Row(
text: "View Brave Histogram (p3a) Logs",
selection: { [unowned self] in
let histogramsController = self.p3aUtilities.histogramsController().then {
$0.title = "Histograms (p3a)"
}
self.navigationController?.pushViewController(histogramsController, animated: true)
}, accessory: .disclosureIndicator, cellClass: MultilineValue1Cell.self),
Row(
text: "VPN Logs",
selection: { [unowned self] in
Expand Down
4 changes: 3 additions & 1 deletion Sources/Onboarding/Welcome/WelcomeViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,9 @@ public class WelcomeViewController: UIViewController {
)

nextController.setLayoutState(state: state)
present(nextController, animated: true) {

present(nextController, animated: true) { [unowned self] in
self.p3aUtilities.isNoticeAcknowledged = true
Preferences.Onboarding.p3aOnboardingShown.value = true
}
}
Expand Down

0 comments on commit 0ca78cb

Please sign in to comment.