Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Polish preview menu on iOS13 #1499

Closed
anthonypkeane opened this issue Sep 6, 2019 · 1 comment
Closed

Polish preview menu on iOS13 #1499

anthonypkeane opened this issue Sep 6, 2019 · 1 comment
Assignees
@iccub
Labels
enhancement iOS 13 QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.13

Comments

@anthonypkeane
Copy link

Description:

As discussed internally, we need to polish our long-press peek/pop menu

Internal Chat: https://bravesoftware.slack.com/archives/C06UXF3KJ/p1567782520135600
@anthonypkeane anthonypkeane added feature-request blocked: needs design Needs design before work can commence QA/Yes labels Sep 6, 2019
@iccub iccub assigned iccub and unassigned jamesmudgett Oct 7, 2019
iccub added a commit that referenced this issue Oct 8, 2019
@iccub
Fix #1499: Better context menu for iOS13
298865a
@iccub iccub mentioned this issue Oct 8, 2019
Merged
7 tasks
iccub added a commit that referenced this issue Oct 9, 2019
@iccub
Fix #1499: Better context menu for iOS13
575642d
iccub added a commit that referenced this issue Oct 10, 2019
@iccub
Ref #1499: Add link preview to long press context.
44946a9
@iccub iccub added this to the 1.13 milestone Oct 10, 2019
@iccub iccub added release-notes/include and removed blocked: needs design Needs design before work can commence release-notes/exclude labels Oct 10, 2019
iccub added a commit that referenced this issue Oct 14, 2019
@iccub
Ref #1499: Add link preview to long press context menu. (#1625)
1f6fe66 
Two notes:
- Link preview can be disabled
- If url is too long we truncate it, 100 characters limit
@srirambv
Copy link
Contributor

Verification passed on iPhone Xr with iOS 13.2 running 1.13(19.10.16.18)

  • Verification passed on normal tab
    image
  • Verification passed on private tab
    image

Verification passed on iPad Pro with iOS 13.2 running 1.13(19.10.16.18)

  • Verification passed on normal tab
    image
  • Verification passed on private tab
    image

Verification passed on iPhone 7+ with iOS 13.2 running 1.13(19.10.16.18)

  • Verification passed on normal tab
    image
  • Verification passed on private tab
    image

@iccub iccub mentioned this issue Oct 26, 2019
Closed
@srirambv srirambv mentioned this issue Nov 8, 2019
Closed
@kylehickinson kylehickinson mentioned this issue Nov 15, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
enhancement iOS 13 QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.13
Development

No branches or pull requests
4 participants
@jamesmudgett @iccub @anthonypkeane @srirambv