This repository has been archived by the owner on May 10, 2024. It is now read-only.
Ref #1499: Add link preview to long press context menu. #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
changed the title
kylehickinson
suggested changes
Oct 10, 2019
| @@ -2511,11 +2511,21 @@ extension BrowserViewController: WKUIDelegate { | |||
| return UIMenu(title: url.absoluteString, children: actions) | |||
| } | |||
|
|
|||
| let config = UIContextMenuConfiguration(identifier: nil, previewProvider: nil, actionProvider: actionProvider) | |||
| let linkPreview: UIContextMenuContentPreviewProvider = { | |||
| return SFSafariViewController(url: url) | |||
There was a problem hiding this comment.
Is it possible to make our own preview provider that uses BVC in some way (so shields are loaded in and such)
There was a problem hiding this comment.
UIContextMenuContentPreviewProvider accepts any UIViewController so we could try to add some custom view with content blocker lists
|
Sorry that review meant to be |
|
I think I should add a preference to hide preview links, similar to what Safari does at the moment |
iccub
added
the
blocked
iccub
removed
the
blocked
|
Added content blocking to the link preview and an option to hide link previews
|
kylehickinson
suggested changes
Oct 11, 2019
|
Ahhh, never mind, that list scrolls, and wasn't visible because of the super long URL… Not sure if we should truncate it? |
|
Added a 100char truncate to it, Safari truncates it too btw
|
Brandon-T
approved these changes
Oct 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Submitter Checklist:
NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement