Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Incorrect message for ads grant in rewards panel #1908

Closed
srirambv opened this issue Nov 6, 2019 · 2 comments
Closed

Incorrect message for ads grant in rewards panel #1908

srirambv opened this issue Nov 6, 2019 · 2 comments
Assignees
@iccub
Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.14

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 6, 2019

Description:

Incorrect message for ads grant in rewards panel

Steps to Reproduce

  1. Wait for ads grant to show up
  2. Got to settings

Actual result:
image

Expected result:
Similar to desktop
image

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.13(19.11.5.20)

Device details:
iPhone

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@srirambv srirambv added this to the 1.14 milestone Nov 6, 2019
@iccub iccub self-assigned this Nov 6, 2019
iccub added a commit that referenced this issue Nov 6, 2019
@iccub
Fix #1908: Correct message for claiming ads earning view.
64f0d08
@iccub iccub mentioned this issue Nov 6, 2019
Merged
7 tasks
@iccub iccub added bug and removed blocked: needs design Needs design before work can commence labels Nov 6, 2019
iccub added a commit that referenced this issue Nov 6, 2019
@iccub
Fix #1908: Correct message for claiming ads earning view.
466731c
@kylehickinson kylehickinson modified the milestones: 1.14, 1.15 Nov 6, 2019
@anthonypkeane anthonypkeane modified the milestones: 1.15, 1.14 Nov 6, 2019
@anthonypkeane
Copy link

Linked to: #1660

This was referenced Nov 21, 2019
Closed
Closed
Closed
Closed
@srirambv
Copy link
Contributor Author

  • Verification passed on iPhone XR with iOS 13.2 running 1.14(19.11.20.19)
    image
  • Verification passed on iPhone 7+ with iOS 13.2 running 1.14(19.11.20.19)
    image
  • Verification passed on iPad Pro with iOS 13.2 running 1.14(19.11.20.19)
    image
  • Verification passed on iPhone 6 with iOS 12.4 running 1.14(19.11.20.19)
    image
  • Verification passed on iPad Pro with iOS 12.4 running 1.14(19.11.20.19)
    image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.14
Development

No branches or pull requests
4 participants
@kylehickinson @iccub @anthonypkeane @srirambv