This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #1908: Correct message for claiming ads earning view. #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
commented
Nov 6, 2019
| } else { | ||
| textLabel.text = Strings.SettingsAdsGrantText | ||
| textLabel.text = Strings.NotificationEarningsClaimDefault |
There was a problem hiding this comment.
fallbacks to Your rewards from Ads are here! if no amount is provided
iccub
commented
Nov 6, 2019
| if let amount = amount { | ||
| textLabel.text = String(format: Strings.SettingsAdsGrantText, "\(amount) \(Strings.BAT) ") | ||
| textLabel.text = "\(amount) \(Strings.BAT) " + Strings.SettingsAdsGrantText |
There was a problem hiding this comment.
This string is not formatted, there is a chance that it may not sound correctly for all languages, we could always fall back to using the NotificationEarningsClaimDefault for all cases
kylehickinson
suggested changes
Nov 6, 2019
| if let amount = amount { | ||
| textLabel.text = String(format: Strings.SettingsAdsGrantText, "\(amount) \(Strings.BAT) ") | ||
| textLabel.text = "\(amount) \(Strings.BAT) " + Strings.SettingsAdsGrantText |
There was a problem hiding this comment.
Can we just add this to the string formatter like so:
"\(amount) \(Strings.BAT) \(Strings.SettingsAdsGrantText)"
kylehickinson
approved these changes
Nov 6, 2019
|
Probably block on merging until 1.13 has officially been submitted? |
|
yep, don't merge if this isnt going into 1.13 |
iccub
added
the
blocked
kylehickinson
removed
the
blocked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Note: Sriram marked this ticket for 1.14, if we want to get it in along with other more important tickets to 1.13 the milestone needs to be updated.
This pull request fixes issue #1908
Submitter Checklist:
NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement