Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Pop-over messages should not be shown on NTP #3496

Closed
soner-yuksel opened this issue Mar 31, 2021 · 1 comment · Fixed by #3497
Closed

Pop-over messages should not be shown on NTP #3496

soner-yuksel opened this issue Mar 31, 2021 · 1 comment · Fixed by #3497

Comments

@soner-yuksel
Copy link
Contributor

Description:
The pop-over messages are being shown when NTP is on active display.

Steps to Reproduce

Actual result:

Image from iOS (20)

Expected result:

No pop-over should be presented on NTP

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily reproduced,

Brave Version:
1.24(21.3.25.18)

Device details:
All

Website problems only:

did you check with Brave Shields down? N_A
did you check in Safari/Firefox (WkWebView-based browsers)? N_A

@srirambv
Copy link
Contributor

srirambv commented Apr 1, 2021

Verification passed on iPhone 7+ with iOS 14.4.2 running 1.24(21.3.31.15)

  • Verified steps from issue description
  • Verified notification is only shown when a page is loaded in a tab

Verification passed on iPhone XR with iOS 13.5 running 1.24(21.3.31.15)

  • Verified steps from issue description
  • Verified notification is only shown when a page is loaded in a tab

Verification passed on iPad Pro with iOS 12.4.1 running 1.24(21.3.31.15)

  • Verified steps from issue description
  • Verified notification is only shown when a page is loaded in a tab

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.