This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #2981: Social Sharing #3387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
suggested changes
Mar 9, 2021
Client/Frontend/Browser/BrowserViewController/BrowserViewController+ProductNotification.swift
Outdated
Show resolved
Hide resolved
Client/Frontend/Browser/BrowserViewController/BrowserViewController+ProductNotification.swift
Outdated
Show resolved
Hide resolved
Client/Frontend/Shields/ShieldsActivityItemSourceProvider.swift
Outdated
Show resolved
Hide resolved
Client/Frontend/Shields/ShieldsActivityItemSourceProvider.swift
Outdated
Show resolved
Hide resolved
| let attachment = ViewTextAttachment(view: self.infoButton) | ||
| string.append(NSAttributedString(attachment: attachment)) | ||
| // Share UI only exist in locale JP | ||
| if Locale.current.regionCode != "JP" { |
There was a problem hiding this comment.
shouldn't this check for JP existence, not the other way around?
There was a problem hiding this comment.
No we add the question mark for help navigation as text attachment normally. In JP locale we are changing this to new button design with share.
soner-yuksel
force-pushed
the
feature/app-virality-increase
branch
from
9a99c83
to
8287c09
Compare
soner-yuksel
force-pushed
the
feature/app-virality-increase
branch
from
60eac9d
to
8287c09
Compare
Brandon-T
suggested changes
Mar 11, 2021
Client/Frontend/Shields/ShieldsActivityItemSourceProvider.swift
Outdated
Show resolved
Hide resolved
Brandon-T
approved these changes
Mar 12, 2021
soner-yuksel
force-pushed
the
feature/app-virality-increase
branch
from
a9235bc
to
0f3e67b
Compare
…different item share is added
soner-yuksel
force-pushed
the
feature/app-virality-increase
branch
from
0f3e67b
to
06d1203
Compare
Closed
This was referenced Mar 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request is implementing the changes on Brave Shields to promote sharing
The implementation currently adding all Sharing features like creating the tracker tier and changes to educational onboarding and changes to the Brave shield screen and actually sharing with Activity Controller.
For sharing Part we are getting a screenshot of Global Stats View and sharing it with additional text. For some sharing types like whatsapp, slack, instagram etc.., we are expanding the snapshotted image and drawing text inside the image with CoreGraphics,
Summary of Changes
This pull request fixes #2981
Submitter Checklist:
NSLocalizableString()Test Plan:
Part1:
Press Brave Shields on Top Bar
Checkout the changes on blocked row
Press the share button and checkout the share type screen with row types
Part2:
Hit one of the block count tier number on Browser
Press the share button and checkout the share type screen with row types
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement