Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[Follow up #3340] Missing translations for Add custom search engines #3498

Closed
srirambv opened this issue Apr 1, 2021 · 1 comment · Fixed by #3500
Closed

[Follow up #3340] Missing translations for Add custom search engines #3498

srirambv opened this issue Apr 1, 2021 · 1 comment · Fixed by #3500
Labels
bug Epic: Localization l10n translation issues QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.24

Comments

@srirambv
Copy link
Contributor

srirambv commented Apr 1, 2021

Description:

[Follow up #3340] Missing translations for Add custom search engines

Steps to Reproduce

  1. Use JP locale and add search engines

Actual result:

image image

Expected result:
Translated strings

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.24

Device details:
All

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@srirambv srirambv added this to the 1.24 milestone Apr 1, 2021
iccub added a commit that referenced this issue Apr 1, 2021
@iccub
Fix #3498: Update 1.24 translations.
df5e93d
@iccub iccub mentioned this issue Apr 1, 2021
Merged
7 tasks
iccub added a commit that referenced this issue Apr 1, 2021
@iccub
Fix #3498: Update 1.24 translations (#3500)
7ee352f
@srirambv
Copy link
Contributor Author

srirambv commented Apr 1, 2021

Verification passed on iPhone 7+ with iOS 14.4.2 running 1.24(21.4.1.15)

  • Verified Add custom search engine messages are translated
Add SE confirmation Added SE message Add SE automatic confirmation
image image image

Verification passed on iPhone XR with iOS 13.5 running 1.24(21.4.1.15)

  • Verified Add custom search engine messages are translated
Add SE confirmation Added SE message Add SE automatic confirmation
image image image

Verification passed on iPad Pro with iOS 12.4.1 running 1.24(21.4.1.15)

  • Verified Add custom search engine messages are translated
Add SE confirmation Added SE message Add SE automatic confirmation
image image image

iccub added a commit that referenced this issue Apr 6, 2021
@iccub
Fix #3498: Update 1.24 translations (#3500)
09a21c5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Epic: Localization l10n translation issues QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.24
Development

Successfully merging a pull request may close this issue.

Fix #3498: Update 1.24 translations brave/brave-ios
2 participants
@iccub @srirambv