Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add 1.24 translations #3340

Closed
iccub opened this issue Feb 23, 2021 · 7 comments · Fixed by #3448
Closed

Add 1.24 translations #3340

iccub opened this issue Feb 23, 2021 · 7 comments · Fixed by #3448

Comments

@iccub
Copy link
Contributor

iccub commented Feb 23, 2021

No description provided.

@srirambv
Copy link
Contributor

@iccub will this include translations for #3387?

@iccub
Copy link
Contributor Author

iccub commented Mar 19, 2021

Yes @srirambv, all translations are there

@iccub
Copy link
Contributor Author

iccub commented Mar 19, 2021

Perhaps we could label tickets needing translation checking

@srirambv
Copy link
Contributor

Yes that would be better. We can add a l10n required label for issues whenever there is a new text implemented. On Desktop/Android there was a new checklist item that got added to PR's that required uplifts. @bsclifton can we get that check done for iOS as well?

iccub added a commit that referenced this issue Mar 22, 2021
@iccub iccub self-assigned this Mar 22, 2021
iccub added a commit that referenced this issue Mar 22, 2021
@bsclifton
Copy link
Member

bsclifton commented Mar 22, 2021

Since iOS doesn't have the concept of uplifts (or at least I don't think they do formally) - I like the idea of slapping a l10n required label on issues 😄

We can then (maybe during triage?) pull up the milestone, see if any have this label, and then schedule the order. Similarly, if there's only 1 issue, then we could make a decision to push back a release if it's too late for an order

@srirambv
Copy link
Contributor

srirambv commented Apr 1, 2021

Verification passed on iPhone 7+ with iOS 14.2 running 1.24(21.4.1.15)

  • Verified new text is all translated

Verification passed on iPhone XR with iOS 13.5 running 1.24(21.4.1.15)

  • Verified new text is all translated

Verification passed on iPad Pro with iOS 12.4.1 running 1.24(21.4.1.15)

  • Verified new text is all translated

@kjozwiak
Copy link
Member

kjozwiak commented Apr 2, 2021

Verification PASSED on iPhone 11 running iOS 14.4.2 using 1.24 (21.4.1.15)

Example (Spanish) Example (Spanish) Example (Spanish) Example (Spanish)
IMG_3661 IMG_3662 IMG_3663 IMG_3664

Verification PASSED on iPad Mini 4 running iOS 13.7 using 1.24 (21.4.1.15)

Example (Polish) Example (Polish) Example (Polish) Example (Polish)
IMG_0514 IMG_0515 IMG_0516 IMG_0518

Verification PASSED on iPad Mini 4 running iOS 13.7 using 1.24 (21.4.1.15)

Example (German) Example (German) Example (German) Example (German)
IMG_0184 IMG_0185 IMG_0187 IMG_0186

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants