Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Use page color under status bar when using bottom bar #7479

Closed
kylehickinson opened this issue May 17, 2023 · 1 comment · Fixed by #7480
Closed

Use page color under status bar when using bottom bar #7479

kylehickinson opened this issue May 17, 2023 · 1 comment · Fixed by #7480

Comments

@kylehickinson
Copy link
Collaborator

Description:

Feature request from Anthony. The little gray bar at the top of the screen under the status bar should match page headers as a nice bit of polish. Safari has a similar feature when you enable "Allow Website Tinting" (from Settings.app > Safari) but they also tint the toolbars which we will not do in Brave

Brave

@hffvld
Copy link
Collaborator

hffvld commented Jun 2, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.5]
Version: 1.52 (23.6.1.16)
BraveCore: 1.52.117 (114.0.5735.90)

STEPS:

  1. Launch Brave
  2. Three-dot Menu > Settings > Enable Top Bar
  3. Open different websites with different background color > Verify
  4. Three-dot Menu > Settings > Enable Bottom Bar
  5. Open different websites with different background color > Verify

ACTUAL RESULTS:

  • Verified that visiting certain pages update the status bar background color to match headers
  • Verified that going back to NTP goes back to the toolbar color
  • Verified that switching between tabs switches the colors accordingly
  • Verified that when the top bar changes to a dark color that the status bar (time/wifi/etc.) shows white text (and that going to other places like tab switcher reverts back)
  • Verify that none of the above happens when not using Bottom bar or Landscape Mode
Bottom Bar is ON. Portrait Mode - PASS
1 2 3 4
1 2 3 4
Bottom Bar is ON. Landscape Mode - PASS
1 2 3 4
1 2 3 4
Bottom Bar is OFF. Portrait Mode - PASS
1 2 3 4
1 2 3 4
Bottom Bar is OFF. Landscape Mode - PASS
1 2 3 4
1 2 3 4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.