Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7479: Use top page color sampling for status bar overlay view color #7480

Merged
merged 1 commit into from
May 18, 2023

Conversation

kylehickinson
Copy link
Collaborator

Summary of Changes

This pull request fixes #7479

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Verify visiting certain pages update the status bar background color to match headers (Note: YouTube's header is technically white, not black which is what you'd expect)
  • Verify going back to NTP goes back to toolbar color
  • Verify switching between tabs switches the colors accordingly
  • Verify that when the top bar changes to a dark color that the status bar (time/wifi/etc.) shows white text (and that going to other places like tab switcher reverts back)
  • Verify that none of the above happens when not using bottom bar

Screenshots:

GitHub 9to5Mac TheVerge
Simulator Screenshot - iPhone 14 Pro - 2023-05-17 at 17 11 16 Simulator Screenshot - iPhone 14 Pro - 2023-05-17 at 17 13 14 Simulator Screenshot - iPhone 14 Pro - 2023-05-17 at 17 10 55

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested a review from a team as a code owner May 17, 2023 21:16
@kylehickinson kylehickinson added this to the 1.52 milestone May 18, 2023
@kylehickinson kylehickinson merged commit 7f42f66 into development May 18, 2023
@kylehickinson kylehickinson deleted the sampled-top-page-color branch May 18, 2023 14:19
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use page color under status bar when using bottom bar
2 participants