Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Rewards inline tipping functionality #105

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Remove Rewards inline tipping functionality #105

merged 1 commit into from
Nov 15, 2023

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Nov 15, 2023 •
edited
Loading

Resolves brave/brave-browser#34367

Test Plan

  • Run brave with the --show-component-extension-options switch and verify that only 13 Greaselion extensions are listed (2 each for the 6 Rewards-related publishers and 1 for Brave Talk)
  • Visit github.com, reddit.com, and twitter.com and for each site verify that the DevTools console mentions loading (for example) githubBase and githubAutoContribution but not githubInlineTipping
  • Verify that a browser release PRIOR to 1.62 with this component installed DOES show inline tip options in brave://settings/rewards but does NOT show inline tip buttons on Twitter/GitHub/Reddit
  • Verify the previous step with 1.62 and this component as well.

@emerick emerick self-assigned this Nov 15, 2023
mkarolin
mkarolin approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emerick emerick merged commit 4b164dc into master Nov 15, 2023
6 checks passed
@emerick emerick deleted the emerick-rewards-remove-inline-tipping-functionality branch November 15, 2023 17:41
@LaurenWags LaurenWags mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarolin mkarolin mkarolin approved these changes

@zenparsing zenparsing Awaiting requested review from zenparsing zenparsing is a code owner

Assignees

@emerick emerick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Rewards inline tipping functionality
2 participants
@emerick @mkarolin