don't show USD conversion in wallet monthly tip

Fixes brave/brave-browser#4503.
brave · Jun 4, 2019 · 8113333 · 8113333
1 parent 0139aa3
commit 8113333
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 12 deletions.
diff --git a/src/features/rewards/walletPanel/index.tsx b/src/features/rewards/walletPanel/index.tsx
@@ -24,6 +24,7 @@ import {
   StyleToggleTips,
   StyledNoticeWrapper,
   StyledNoticeLink,
+  StyledOptionShown,
   StyledProfileWrapper,
   StyledSelect
 } from './style'
@@ -98,25 +99,27 @@ export default class WalletPanel extends React.PureComponent<Props, {}> {
     return (
       <StyledSelectWrapper>
         <StyledSelect
-          value={monthlyAmount}
+          value={'show'}
           onChange={this.props.onAmountChange}
         >
           {donationAmounts.map((token: Token, index: number) => {
-            const tokenValue = token.tokens.toString()
-            const paddingLength = tokenValue.length < 5
-              ? tokenValue.length === 4 ? 3 : 4
-              : 0
-            const padding = `${String.fromCharCode(160)}`.repeat(paddingLength)
-
             return (
               <option
                 key={`k-${token.tokens}`}
-                value={tokenValue}
+                value={token.tokens}
               >
-                {padding}{token.tokens} {getLocale('bat')} ({token.converted} USD)
+                {token.tokens} {getLocale('bat')} ({token.converted} USD)
               </option>
             )
-          })}
+          }).concat(
+             <StyledOptionShown
+               key={'k-show'}
+               value={'show'}
+               disabled={true}
+             >
+               {monthlyAmount} {getLocale('bat')}
+             </StyledOptionShown>
+          )}
         </StyledSelect>
       </StyledSelectWrapper>
     )

diff --git a/src/features/rewards/walletPanel/style.ts b/src/features/rewards/walletPanel/style.ts
@@ -123,3 +123,7 @@ export const StyledSelect = styled<StyleProps, 'select'>('select')`
     outline: 0;
   }
 `
+
+export const StyledOptionShown = styled<{}, 'option'>('option')`
+  display: none;
+`
diff --git a/src/features/rewards/walletSummary/__snapshots__/spec.tsx.snap b/src/features/rewards/walletSummary/__snapshots__/spec.tsx.snap
@@ -185,7 +185,7 @@ exports[`WalletSummary tests basic tests matches the snapshot 1`] = `
     <div
       className="c3"
     >
-      MISSING: monthMay
+      MISSING: monthJun
        
       2019
     </div>

diff --git a/stories/features/rewards/concepts.tsx b/stories/features/rewards/concepts.tsx
@@ -427,7 +427,7 @@ storiesOf('Feature Components/Rewards/Concepts/Desktop', module)
               platform={'youtube'}
               publisherImg={favicon}
               publisherName={'Jonathon Doe'}
-              monthlyAmount={'5.0'}
+              monthlyAmount={text('Monthly contribution', '5.0')}
               acEnabled={true}
               isVerified={boolean('Verified', false)}
               showUnVerified={boolean('Show Unverified', true)}