Merge pull request #11771 from brave/ca--11460

fallback to placeholder when currency address is fetching
brave · Nov 3, 2017 · 134f8ee · 134f8ee
1 parent 13e6e16
commit 134f8ee
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/app/extensions/brave/locales/en-US/preferences.properties b/app/extensions/brave/locales/en-US/preferences.properties
@@ -93,6 +93,7 @@ createWallet=create wallet
 createWalletStatus=Click the Create Wallet button to get started.
 creatingWallet=creating…
 creatingWalletStatus=Creating wallet…
+loadingWalletAddress.placeholder=Loading wallet address…
 dashboardSettingsTitle=Dashboard
 dashboardShowImages=Show images
 dashlane=Dashlane&reg; (requires application)

diff --git a/app/renderer/components/common/textbox.js b/app/renderer/components/common/textbox.js
@@ -35,10 +35,10 @@ class GroupedFormTextbox extends ImmutableComponent {
     return (
       <div className={css(styles.groupedFormTextBox)}>
         <input
+          data-l10n-id={this.props.l10nId}
           ref={this.props.inputRef}
           type={this.props.type}
           readOnly={this.props.readOnly}
-          placeholder={this.props.placeholder}
           defaultValue={this.props.value}
           className={css(
             styles.groupedFormTextBox__firstGroupedItem,

diff --git a/app/renderer/components/preferences/payment/addFundsDialog/steps/addFundsWizardAddress.js b/app/renderer/components/preferences/payment/addFundsDialog/steps/addFundsWizardAddress.js
@@ -98,6 +98,7 @@ class AddFundsWizardAddress extends React.Component {
           <main className={css(styles.wizardAddress__inputBox)}>
             <div>
               <GroupedFormTextbox readOnly
+                l10nId='loadingWalletAddress'
                 type='text'
                 inputRef={(node) => { this.addressInputNode = node }}
                 value={this.props.address}