This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
fallback to placeholder when currency address is fetching #11771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11771 +/- ##
=======================================
Coverage 52.75% 52.75%
=======================================
Files 269 269
Lines 25668 25668
Branches 4097 4097
=======================================
Hits 13542 13542
Misses 12126 12126
|
|
@cezaraugusto not sure why this PR would close #11460? |
|
ya @bradleyrichter said so |
|
ok 😄 |
bsclifton
added a commit
that referenced
this pull request
Nov 3, 2017
fallback to placeholder when currency address is fetching
bsclifton
added a commit
that referenced
this pull request
Nov 3, 2017
fallback to placeholder when currency address is fetching
bsclifton
added a commit
that referenced
this pull request
Nov 3, 2017
fallback to placeholder when currency address is fetching
bbondy
modified the milestones:
0.19.x Hotfix 5 (Release channel),
0.19.x Hotfix 4 (Release channel)
|
Use case mentioned in #11589 (comment). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11460
fix #11589
Input placeholder should be filled in case the wallet address is still fetching. Solution matches Brad spec.