Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ledger getPublisher perf is bad even if ledger is off #10186

Closed
bbondy opened this issue Jul 28, 2017 · 1 comment
Closed

Ledger getPublisher perf is bad even if ledger is off #10186

bbondy opened this issue Jul 28, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
perf QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.18.23 Hotfix

Comments

@bbondy
Copy link
Member

bbondy commented Jul 28, 2017 •
edited by luixxiul
Loading

Test plan

#10192 (comment)

All typing and mouse movement call into getPublisher which can be expensive.

screen shot 2017-07-28 at 10 47 40 am

See also: #9311

I think mainly the problem is when publisher info isn't found it keeps looking for it. We could store that it was looked up but not found and then not re-lookup in that case. But also I think it's not needed to be even called into for cases like mouse move and key down.
@bbondy bbondy added this to the 0.18.x Hotfix milestone Jul 28, 2017
@bsclifton bsclifton mentioned this issue Jul 28, 2017
Closed
35 tasks
@bbondy bbondy added perf hackathon Legacy label for a hackaton. labels Jul 28, 2017
@bbondy
Copy link
Member Author

bbondy commented Jul 28, 2017

@NejcZdovc volunteered for this

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 28, 2017
@NejcZdovc
Removes unnecessary setFocusedFrame calls
94433f9 
Resolves brave#10186

Auditors: @bbondy

Test Plan:
- run a profiler and check that ledger is not called when hovering over links or typing in find bar
@NejcZdovc NejcZdovc mentioned this issue Jul 28, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 29, 2017
@NejcZdovc
Removes unnecessary setFocusedFrame calls
06f7be9 
Resolves brave#10186

Auditors: @bbondy

Test Plan:
- run a profiler and check that ledger is not called when hovering over links or typing in find bar
@luixxiul luixxiul removed the hackathon Legacy label for a hackaton. label Jul 30, 2017
bbondy added a commit that referenced this issue Aug 1, 2017
@bbondy
Merge pull request #10192 from NejcZdovc/hotfix/#10186-ledger-perf
3083dd9 
Removes unnecessary setFocusedFrame calls
bbondy added a commit that referenced this issue Aug 1, 2017
@bbondy
Merge pull request #10192 from NejcZdovc/hotfix/#10186-ledger-perf
8e6b00a 
Removes unnecessary setFocusedFrame calls
bbondy added a commit that referenced this issue Aug 1, 2017
@bbondy
Merge pull request #10192 from NejcZdovc/hotfix/#10186-ledger-perf
5c83a83 
Removes unnecessary setFocusedFrame calls
bbondy added a commit that referenced this issue Aug 1, 2017
@bbondy
Merge pull request #10192 from NejcZdovc/hotfix/#10186-ledger-perf
1cc10f8 
Removes unnecessary setFocusedFrame calls
This was referenced Aug 7, 2017
Closed
Closed
Closed
Closed
This was referenced Aug 9, 2017
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 11, 2017
Closed
Closed
Closed
This was referenced Aug 16, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
perf QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.18.23 Hotfix
Development

No branches or pull requests
5 participants
@bbondy @luixxiul @NejcZdovc @srirambv @LaurenWags