Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

move frame hrefPreview to a separate component #10194

Closed
bridiver opened this issue Jul 28, 2017 · 0 comments
Closed

move frame hrefPreview to a separate component #10194

bridiver opened this issue Jul 28, 2017 · 0 comments
Assignees
@NejcZdovc
Labels
perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@bridiver
Copy link
Collaborator

bridiver commented Jul 28, 2017 •
edited by luixxiul
Loading

Test plan

#10282 (comment)

link hovers trigger a re-render of the entire Frame component and can potentially be called quite frequently while moving the mouse over the page. We could eliminate that by splitting out the hrefPreview into a separate component so it isn't part of the frame props
@NejcZdovc NejcZdovc added the hackathon Legacy label for a hackaton. label Jul 29, 2017
@NejcZdovc NejcZdovc added this to the 0.19.x (Beta Channel) milestone Aug 3, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 3, 2017
@NejcZdovc
Moves hrePreview from Frame
b181999 
Resolves brave#10194

Auditors: @bsclifton

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Aug 3, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 3, 2017
@NejcZdovc
Moves hrePreview from Frame
dad3f11 
Resolves brave#10194

Auditors: @bsclifton

Test Plan:
@bsclifton bsclifton mentioned this issue Aug 3, 2017
Closed
35 tasks
NejcZdovc added a commit that referenced this issue Aug 5, 2017
@NejcZdovc
Merge pull request #10282 from NejcZdovc/hotfix/#10194-hrefpreview
c91b1c9 
Moves hrefPreview from Frame
NejcZdovc added a commit that referenced this issue Aug 5, 2017
@NejcZdovc
Moves hrePreview from Frame
bad75d3 
Resolves #10194

Auditors: @bsclifton

Test Plan:
NejcZdovc added a commit that referenced this issue Aug 5, 2017
@NejcZdovc
Moves hrePreview from Frame
5e2d739 
Resolves #10194

Auditors: @bsclifton

Test Plan:
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@NejcZdovc @dfperry5
Moves hrePreview from Frame
fef6f54 
Resolves brave#10194

Auditors: @bsclifton

Test Plan:
This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul added QA/checked-Linux and removed hackathon Legacy label for a hackaton. labels Sep 20, 2017
This was referenced Sep 20, 2017
Closed
Closed
This was referenced Sep 21, 2017
Closed
Closed
This was referenced Sep 25, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
5 participants
@bridiver @luixxiul @NejcZdovc @srirambv @LaurenWags