Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

add error to Transition Overlay if error occurs when changing wallet from BTC -> BAT #11460

Closed
LaurenWags opened this issue Oct 11, 2017 · 7 comments · Fixed by #11771
Closed
Labels
design A design change, especially one which needs input from the design team. feature/rewards initiative/bat-payments wontfix

Comments

@LaurenWags
Copy link
Member

Description

BTC --> BAT wallet is taking more time than expected during QA (30-40+ minutes). Per discussions, if an error occurs during this process we should display this error on the transition overlay/progress screen. TBD: wording for this and if we show generic error or raw error. cc @davidtemkin @bsclifton @NejcZdovc

Steps to Reproduce

Actual result:
If error occurs, there isn't an indication on the transition overlay.

Expected result:
Error to be displayed, text and what kind of error are TBD.

Reproduces how often: [What percentage of the time does it reproduce?] unknown

Brave Version

about:brave info:
Brave | 0.19.43
rev | 24df93d
Muon | 4.4.27

Reproducible on current live release:
n/a

Additional Information

@LaurenWags LaurenWags added this to the 0.19.x (Beta Channel) milestone Oct 11, 2017
@bsclifton bsclifton added the priority/P4 Minor loss of function. Workaround usually present. label Oct 11, 2017
@bsclifton
Copy link
Member

moving to 0.19.x release 2- for the time being, we can advise folks to run command line with LEDGER_VERBOSE=true and share logs. In order to handle this issue properly, we'd need a decision on what text to show (above) and we'd need to know how it should look
cc: @bradleyrichter @davidtemkin

@cezaraugusto
Copy link
Contributor

adding needs-info as this requires input from outside engineering team

@cezaraugusto cezaraugusto added the needs-info Another team member needs information from the PR/issue opener. label Oct 23, 2017
@alexwykoff alexwykoff added design A design change, especially one which needs input from the design team. needs-mockup A feature which needs design mockup to be implemented. labels Oct 24, 2017
@bsclifton
Copy link
Member

@bradleyrichter is this issue sufficiently addressed by putting "Loading..." in the address field? (see #11771)

@bsclifton
Copy link
Member

Moving out from milestone 😄 We'll need to solve this. I'll assign myself and document possible error states so that we can create mock ups

@bsclifton
Copy link
Member

bsclifton commented Nov 8, 2017

Without specific examples, here are the main use-cases we can create a generic message for:

  • can't reach server (internet is down, etc)
  • a very specific error is returned from eyeshade (probably not something we want to display as-is)
  • a generic 422 or 503 error is returned (server is busy / unprocessable)

@bsclifton bsclifton removed their assignment Nov 8, 2017
@bsclifton
Copy link
Member

cc: @alexwykoff @bradleyrichter @jenn-rhim for mockup

syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@NejcZdovc
Copy link
Contributor

close it as won't fix, because we should be good now

@luixxiul luixxiul added wontfix and removed needs-info Another team member needs information from the PR/issue opener. needs-mockup A feature which needs design mockup to be implemented. priority/P4 Minor loss of function. Workaround usually present. labels Nov 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/rewards initiative/bat-payments wontfix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants